Amélioration du last login et du ping #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unts have long names shevabam#27
A ping which is not possible resulted in a "0 ms" value which is not consistent with the reality. A "+Infinity" is more appropriate.
Since a ping may fail, it is relevant to use the w15p class in order to show if the ping was successful or not. Moreover, showing the time of a not valid ping is not relevant and it means the server is offline.
This will show the IP of the user and the connection date
like this: "Jan 27 2016 16:27:59" which is more appropriate
than the previous version ("Jan Wed +0100 27").
MisterCyp
added a commit
that referenced
this pull request
Mar 3, 2016
Amélioration du last login et du ping
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.