Fix Flattening Bounds Control Bug #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bug occurs when setting Bounds Control's Flatten Mode to Auto or Always, specifically when the GO's scale does not correspond to the bounding box scale.
In SqueezableBoxVisuals, the flattenVector is currently set at Awake(), but the transform changes after this and the flattenVector is not updated, leading to the bug. Based on the old value, it will try to flatten along the wrong axis, which causes problems in subsequent calculations (negative values and division by 0). Fix to simply update flattenVector before calculations.