Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preparing to release UPM Packages to Unity's Asset store. #519

Merged
merged 17 commits into from
Feb 9, 2024
Merged

Preparing to release UPM Packages to Unity's Asset store. #519

merged 17 commits into from
Feb 9, 2024

Conversation

AMollis
Copy link
Contributor

@AMollis AMollis commented Oct 18, 2023 •
edited
Loading

This PR updates MRTK packages so that they can be published to the Unity Asset Store. Doing this required the following changes:

  1. Adding unityRelease and documentationUrl fields to the package.json files.
  2. Adding CHANGELOG.md with correct versioning. After this change PRs must add notable changes to the package's CHANGELOG.md file.
  3. Converted one JPG image to PNG. Unity Asset Store packages can't contain compressed images.
  4. Updated package versions where needed, to reflect changes made after pending release (see Release MRTK3 Packages at commit d9ff8b0 #628)
  5. Added unit tests to validate packages using Unity's "Asset Store Validation" tool.
  6. Updated build scripts to update package's prerelease tags and dates in CHANGELOG.md to the correct value.
  7. Updated sample dependencies to the latest versions that also support the Unity Asset Store. In a future change we should update the sample to use the Unity Asset Store directly.

‼️ Note, the min Unity version supporting UPM Asset Store packages is 2021.3.26f1. That's why you see "unityRelease"="26f1". This change won't prohibit people from obtaining the MRTK packages via the MR Feature Tool for older versions of the Unity.

Depends On

Changes

@AMollis
Preparing for releasing UPM to Unity's Asset store. Adding the requir…
8452add 
…ed `unityRelease` and `documentationUrl` fields to the package.json files. Note, the min Unity version for supporting UPM Asset Store packages is 2021.3.26f1.
@AMollis AMollis self-assigned this Oct 18, 2023
@AMollis AMollis added Type: Release Management An issue tracking and used for managing a release. Package: Core The Project core package is impacted by this issue. Package: Audio The Project audio package is impacted by this issue. Package: Diagnostics The Project diagnostics package is impacted by this issue. Package: Extended Assets The Project extended assets package is impacted by this issue. Package: Input The Project input package is impacted by this issue. Package: Spatial Manipulation The Project spatial manipulation package is impacted by this issue. Package: Standard Assets The Project standard assets package is impacted by this issue. Package: Tools The Project tools package is impacted by this issue. Package: UX Components The Project ux components package is impacted by this issue. Package: UX Components (Non-Canvas) The Project ux component (non-canvas) package is impacted by this issue. Package: UX Core The Project ux core package is impacted by this issue. Package: Windows Speech The Project Windows speech package is impacted by this issue. labels Oct 18, 2023
@AMollis AMollis mentioned this pull request Oct 28, 2023
Open
8 tasks
@AMollis AMollis marked this pull request as ready for review February 7, 2024 06:39
@AMollis
Copy link
Contributor Author

AMollis commented Feb 7, 2024

@MixedRealityToolkit/mixedrealitytoolkit-unity-maintainers This PR is ready for a review

@AMollis AMollis changed the title Preparing for releasing UPM to Unity's Asset store. Preparing to release UPM Packages to Unity's Asset store. Feb 7, 2024
@AMollis
Copy link
Contributor Author

AMollis commented Feb 7, 2024

@keveleigh resolved your two comments. Thank you

@AMollis
Copy link
Contributor Author

AMollis commented Feb 7, 2024

Cleaned up parsing code a bit. Thank you @ms-RistoRK and @keveleigh for feedback

shaynie
shaynie previously approved these changes Feb 9, 2024
View reviewed changes
@shaynie shaynie self-requested a review February 9, 2024 23:20
@AMollis AMollis enabled auto-merge (squash) February 9, 2024 23:35
@AMollis AMollis merged commit 55e2f38 into MixedRealityToolkit:main Feb 9, 2024
4 checks passed
@AMollis AMollis mentioned this pull request Mar 20, 2024
Merged
@AMollis AMollis deleted the user/amollis/main/adding-unity-asset-store-validation branch May 15, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keveleigh keveleigh keveleigh left review comments

@ms-RistoRK ms-RistoRK ms-RistoRK left review comments

@shaynie shaynie shaynie approved these changes

@david-c-kline david-c-kline Awaiting requested review from david-c-kline

@marlenaklein-msft marlenaklein-msft Awaiting requested review from marlenaklein-msft marlenaklein-msft is a code owner

Assignees

@AMollis AMollis

Labels
Package: Audio The Project audio package is impacted by this issue. Package: Core The Project core package is impacted by this issue. Package: Diagnostics The Project diagnostics package is impacted by this issue. Package: Extended Assets The Project extended assets package is impacted by this issue. Package: Input The Project input package is impacted by this issue. Package: Spatial Manipulation The Project spatial manipulation package is impacted by this issue. Package: Standard Assets The Project standard assets package is impacted by this issue. Package: Tools The Project tools package is impacted by this issue. Package: UX Components (Non-Canvas) The Project ux component (non-canvas) package is impacted by this issue. Package: UX Components The Project ux components package is impacted by this issue. Package: UX Core The Project ux core package is impacted by this issue. Package: Windows Speech The Project Windows speech package is impacted by this issue. Type: Release Management An issue tracking and used for managing a release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] Publish MRTK UPM packages to Unity Asset Store
4 participants
@AMollis @keveleigh @shaynie @ms-RistoRK