Fix Canvas Slider Handle Positioning and Impose MinMax Limits to Slider Value #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marlenaklein-msft
requested review from
AMollis,
shaynie and
a team
as code owners
|
LGTM, ship it! |
AMollis
requested changes
Nov 10, 2023
AMollis
approved these changes
Nov 10, 2023
AMollis
added
Package: UX Components
AMollis
requested changes
Nov 10, 2023
Ugh...I was looking at the wrong package.json |
AMollis
approved these changes
Nov 10, 2023
|
Awesome, thank you for this PR! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement fixes related to setting the slider value programmatically: canvas slider handle calculations now use canvas positioning, aligning with fillVisual. Issue and workaround reported by @anonymous2585, #523.
Also adds a check to limit Slider value within the range of min and max values, removes arbitrary prefab value.