Fix controller model fallback serialization #559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were direct variants of the imported glTF models. Unfortunately, it appears that the imported glTF models don't keep a consistent fileID across glTF importer versions. This was causing the reference to the controller model prefabs to be lost in the hand prefabs when different glTF importer versions were used compared to the repo's sample scene.
keveleigh
requested review from
marlenaklein-msft,
AMollis,
shaynie and
a team
as code owners
marlenaklein-msft
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #241, specifically:
It looks like we were hitting a bit of a quirk with the Unity serialization system causing our fallback controller models to lose their reference when different glTFast versions were used compared to our sample scene.
As best as I can tell, the underlying problem is that our prefabs were direct variants of the imported glTF models. Unfortunately, it appears that the imported glTF models don't keep a consistent fileID across glTF importer versions. This caused the reference to the controller model prefabs to be lost in the hand prefabs when different glTF importer versions were used.
This PR updates our prefabs to no longer be direct variants of an imported model, but instead their own prefabs using the meshes/textures/etc from the imported model. From my tests, this ensures a consistent fileID.
I took a brief look around, and it appears these were the only prefabs set up this way.