Allow Variable Bounding Box Handle Sizes #598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marlenaklein-msft
requested review from
AMollis,
shaynie and
a team
as code owners
marlenaklein-msft
changed the title
AMollis
requested changes
Jan 2, 2024
org.mixedrealitytoolkit.spatialmanipulation/BoundsControl/BoundsHandleInteractable.cs
Outdated
Show resolved
Hide resolved
|
@marlenaklein-msft , did you also check if the version numbers need updating? Can you please add a comment to the PR description stating you've verified the package versions are correct? Thank you |
AMollis
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, all BoundsHandleInteractables are set to a global scale of 1x1x1 at runtime (and may then scale with the bounding box if MaintainGlobalSize is unselected). The initial scale of BoundsHandleInteractable is never taken into account when scaling the handles. This change sets the global scale to the max(x,y,z) of the initial BoundsHandleInteractable scale, instead of 1, so a user may now change the size of the handles in the prefab in order to make bounding boxes with larger or smaller handles. PR also makes changes to the BoundsControlRuntimeExample scene to give an example of this.
[3x3x3 Handles Scaled Prefab from Sample Scene]
Addresses #572
Spatial Manipulation package version number has already been bumped since last release, so no update is needed.