Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a way to modify scaling, translation, and rotation logic using manipulationlogic class #722

Conversation

hossambasiony1
Copy link
Contributor

@hossambasiony1 hossambasiony1 commented Apr 18, 2024

Similar to objectmanipulator, boundscontrol.cs now supports custom scaling, translation, and/or rotation logic using handles.

Steps for creating custom logic:

  1. Create your own class that inherits from manipulationlogic class
  2. Add the manipulation logic in Setup() and Update()
  3. Assign the new class for "manipulationLogicTypes" variable in the inspector for the boundscontrol script for whatever manipulation you wish to modify.

Also updated changelog and package.json accordingly.

Copy link
Contributor

@AMollis AMollis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also please undo some of the "access modifier" changes made in https://github.com/MixedRealityToolkit/MixedRealityToolkit-Unity/pull/715/files

  • Change protected virtual internal void OnHandleSelectExited back to internal
  • Change protected virtual void TransformTarget() back to private

Update being protected is fine....since a private Update can be mistakenly hidden and break Unity function events, if someone extends the class.

@AMollis AMollis requested review from keveleigh and a team April 18, 2024 06:27
@AMollis
Copy link
Contributor

AMollis commented Apr 18, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@AMollis AMollis enabled auto-merge (squash) April 18, 2024 18:02
@AMollis
Copy link
Contributor

AMollis commented Apr 19, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@AMollis AMollis merged commit b305917 into MixedRealityToolkit:main Apr 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants