Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing #if for analog and servo #133

Merged
merged 1 commit into from
Jan 29, 2022

Conversation

neilenns
Copy link
Contributor

@neilenns neilenns commented Jan 7, 2022

Fixes #130

  • Add missing #if statements for the analog and servo variables.

  • Re-order the two places where those variables are mentioned to be consistent.

@neilenns
Copy link
Contributor Author

neilenns commented Jan 7, 2022

Here's the flash savings after the change when the analog and servos are disabled via the MFBoard.h file:

image

@github-actions
Copy link

github-actions bot commented Jan 7, 2022

Firmware for this pull request:
Firmware.zip

Copy link
Collaborator

@DocMoebiuz DocMoebiuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THANK YOU!

@DocMoebiuz DocMoebiuz merged commit a35192e into MobiFlight:main Jan 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Analog-specific variables aren't omitted if analog is disabled
2 participants