All boards can crash after upload w/ 4 7Segment #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Firmware for this pull request: |
|
Nice find! |
|
Firmware for this pull request: |
|
Firmware for this pull request: |
|
Unfortunetly I missed one more buffer overflow, but now I should have find all of them. First tests shows that it runs very stable now. |
|
Sorry, I forgot to mention, that this is not only an issue regarding a possible buffer overflow. This "only" happens if the max. number of a device is configured. Much more important is, the memory wasn't cleared up after a config upload if one or more devices from these 6 devices were configured. But I still recommended to merge issue 127. The pull request is nearly done and more explanations will be icluded in the upcoming pull request. |
DocMoebiuz
approved these changes
Jan 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #140
Eexchange ledSegmentsRegistered by i in function ClearLedSegments().
Otherwise the ledSegments[] buffersize will be exceeded when 4 7Segments are configured