Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix off by one error in output shifter indexing #157

Merged
merged 1 commit into from
Feb 27, 2022
Merged

Fix off by one error in output shifter indexing #157

merged 1 commit into from
Feb 27, 2022

Conversation

neilenns
Copy link
Contributor

Fixes #155

Description of changes

  • Added - 1 to array indexing when sending values out to the shift registers
  • Remove commented out code that shouldn't be in the source

@neilenns neilenns requested a review from GioCC February 22, 2022 20:48
@neilenns
Copy link
Contributor Author

Ok new PR that doesn't have whitespace changes

@github-actions
Copy link

Firmware for this pull request:
Firmware.zip

DocMoebiuz
DocMoebiuz approved these changes Feb 27, 2022
View reviewed changes
Copy link
Collaborator

@DocMoebiuz DocMoebiuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@DocMoebiuz DocMoebiuz merged commit b17e8cd into MobiFlight:main Feb 27, 2022
@DocMoebiuz DocMoebiuz modified the milestone: 2.1 Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GioCC GioCC GioCC approved these changes

@DocMoebiuz DocMoebiuz DocMoebiuz approved these changes

Assignees
No one assigned
Labels
beta-bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Output shifters are broken with beta firmware
3 participants
@neilenns @GioCC @DocMoebiuz