Modifications for Digital Input Multiplexers #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- "Include" directory removed (.h files moved to "src") - MFEEPROM.h moved to MF_Modules (.cpp was under "_Boards/Atmel") Other: - Device type constants moved to "config.h" - Header inclusion optimized (main includes collected in "mobifligt.h) - Code formatting and headers made uniform - introduced VS Code formatting config (settings.json)
|
Firmware for this pull request: |
GioCC
reviewed
Apr 2, 2022
_Boards/Atmel/Board_Uno/MFBoards.h
Outdated
| @@ -40,6 +47,8 @@ | |||
| #define MAX_ANALOG_INPUTS 6 | |||
| #define MAX_OUTPUT_SHIFTERS 2 | |||
| #define MAX_INPUT_SHIFTERS 2 | |||
| #define MAX_INPUT_SHIFTERS 2 | |||
There was a problem hiding this comment.
MAX_INPUT_SHIFTERS is repeated
GioCC
suggested changes
Apr 2, 2022
There was a problem hiding this comment.
Only thing I noticed is a repeated line in _Boards/Atmel/Board_Uno/MFBoards.h
GioCC
reviewed
Apr 2, 2022
src/Config.cpp
Outdated
| @@ -71,7 +70,7 @@ void _activateConfig(); | |||
| // ************************************************************ | |||
| // configBuffer handling | |||
| // ************************************************************ | |||
| // reads the EEPROM until NUL terminator and returns the number of characters incl. terminator, starting from given address | |||
| // reads the EEPRROM until NULL termination and returns the number of characters incl. NULL termination, starting from given address | |||
There was a problem hiding this comment.
Not really worth mentioning, but "EEPRROM" is spelled wrong, and the "\0" char is a NUL char used as terminator; NULL is something that has "no" value (or the "placeholder" value representing that).
There was a problem hiding this comment.
Must have happened during the merge.
GioCC
approved these changes
Apr 2, 2022
|
Firmware for this pull request: |
GioCC
approved these changes
Apr 4, 2022
GioCC
approved these changes
Apr 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #119