Remove unused temp variable #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Firmware for this pull request: |
GioCC
approved these changes
Jun 4, 2023
DocMoebiuz
reviewed
Jun 4, 2023
src/Config.cpp
Outdated
| uint16_t addreeprom = MEM_OFFSET_CONFIG; | ||
| uint16_t length = MFeeprom.get_length(); | ||
| configLength = 0; | ||
|
|
||
| while (MFeeprom.read_byte(addreeprom++) != 0x00) { | ||
| configLength++; | ||
| if (addreeprom > length) // abort if EEPROM size will be exceeded | ||
| if (addreeprom > length) // abort if EEPROM size will be exceeded |
There was a problem hiding this comment.
comment alignment. probably due to auto formatting rule.
This comment is also not necessary because it's obvious what is happening.
if length was called eepromLength it would be even more clear.
In general I propose to put comments above the line instead of behind.
There was a problem hiding this comment.
Do you want me to remove the comment as part of this PR? I was only trying to remove the temp variable, I didn't bother touching anything else.
There was a problem hiding this comment.
we can remove it - thanks
neilenns
commented
Jun 4, 2023
|
Firmware for this pull request: |
DocMoebiuz
approved these changes
Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #245
Removes the unused
tempvariable. The variable was introduced here.