-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate PyMEOS #4
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
For a quick idea / shorter diff check the first commit of this PR which serves as the PoC of this integration.
Major changes this diff introduces
PyMEOS
(which is private as of now). As a result, we are able to remove a lot of code, and the code is now more focused on dealing withpsycopg
andasyncpg
.instantN
,timestampN
etc) are now 0-indexed instead of 1-indexedSTBox
- Coordinates not allowed as strings anymorePeriodSet
,TimestampSet
, Instant Sets, Sequences, and Sequence Sets.duration()
function is now a property.duration
and returns an enum insteadWork in Progress
Testing
CI status can be checked for a quick idea.
Note: In CI you will see that stbox tests fail. This is because this PR assumes the patch MobilityDB/MobilityDB#17, but it is not applied in the docker image yet. However, you can see that all other tests pass successfully.
It can also be tested locally. To do so, follow these steps: