Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Add feed_contact_email field to system_information.json #181

Merged
merged 2 commits into from
Jan 3, 2020

Conversation

yocontra
Copy link
Contributor

@yocontra yocontra commented Oct 1, 2019

Issue

Currently as a consumer of a feed, you have no real way to contact the operator of that feed. The email attribute is meant for general support purposes, so doesn't solve this issue. This results in issues being opened on this repository and causes a really painful feedback loop of trying to locate the person who can fix the actual problem. This is particularly relevant as we've been discussing more systematic validation tools for feeds in systems.csv in the GBFS workshop.

Solution

Non-breaking, adds an optional technical_email property to system_information.json where providers can specify where to send bug/validation/etc. reports.

Feedback needed

  • Open to changing the actual property name, but this was the clearest I could come up with.
  • Should email be renamed to support_email to clarify it's purpose?
  • Should this be required and released as a breaking change?
  • Is this useful for feed consumers?
  • Is this easy for operators to add, or is it too much of a burden?

@barbeau
Copy link
Member

barbeau commented Oct 2, 2019

+1 for optional technical_email. I've had the same experience where it took me a long time to track down the person that can actually fix a problem in the feed. GTFS has analogous fields agency_email for transit agency customer support and feed_contact_email as a technical contact.

See issues #149, #177, #178, and #179 for examples of data quality issues being reported on this repo.

Should this be required and released as a breaking change?

IMHO I would say no. It should, however, be a best practice to include the field.

Should email be renamed to support_email to clarify it's purpose?

I don't think that's necessary - the current description makes it's purpose pretty clear - "A single contact email address for customers to address questions about the system"

@yocontra
Copy link
Contributor Author

yocontra commented Oct 2, 2019

@barbeau Thoughts on using feed_contact_email instead of technical_email to align w/ GTFS?

@mplsmitch
Copy link
Collaborator

+1 for aligning the name with GTFS. I think there's a case to be made for this being a required field but that could come later as part of a major release. In the interim it could be added as an optional field.

@barbeau
Copy link
Member

barbeau commented Oct 2, 2019

Using feed_contact_email to align with GTFS works for me.

@yocontra
Copy link
Contributor Author

yocontra commented Oct 2, 2019

Updated.

@kanagy
Copy link

kanagy commented Oct 2, 2019

+1 Thanks for adding this field.

Just a thought: Should this be an array of emails to be more flexible? I don't lean either way. A group alias can always be defined instead.

@jcn
Copy link
Contributor

jcn commented Oct 8, 2019

Should this be an array of emails to be more flexible?

To stay consistent with GTFS and with the existing email field I'd propose sticking to a single valid email address.

@yocontra
Copy link
Contributor Author

yocontra commented Nov 5, 2019

Seems like we have consensus here, what are the next steps for including this in the upcoming version of GBFS?

@jcn
Copy link
Contributor

jcn commented Nov 6, 2019

As an optional field, it seems like this would be ready for the formal approval step with a merge into master, with inclusion into the next minor release.

@antrim
Copy link
Contributor

antrim commented Nov 21, 2019

Hi @contra: Thanks for pinging on this. Please go ahead and call the vote! Here's an example "call the vote" comment: #188 (comment).

@yocontra
Copy link
Contributor Author

I hereby call a vote on this proposal. Voting will be open for 7 full days, until 11:59PM UTC on Thursday, Nov 28.

Please vote for or against the proposal to add the feed_contact_email field, and include the organization for which you are voting in your comment.

@yocontra yocontra changed the title Proposal: Add technical_email field to system_information.json Proposal: Add feed_contact_email field to system_information.json Nov 21, 2019
@jcn
Copy link
Contributor

jcn commented Nov 21, 2019

👍 from me as an independent developer

@barbeau
Copy link
Member

barbeau commented Nov 21, 2019

👍 from me from OneBusAway/USF

Prior to merging this, though, do we need a producer and consumer of the field?

@kanagy
Copy link

kanagy commented Nov 21, 2019

+1 from me from Google Maps

@MuteQ
Copy link

MuteQ commented Nov 22, 2019

+1 from Transit

@mplsmitch
Copy link
Collaborator

👍 from me as an independent mobility enthusiast

@heidiguenin
Copy link
Contributor

@barbeau We do need a producer to vote on this. And as part of the governance pilot, we're going to work on language about implementor commitment happening in parallel with vote.

@heidiguenin
Copy link
Contributor

@kanagy @MuteQ Are either of you able to commit to implementing this change on your end?

@gcamp
Copy link

gcamp commented Nov 22, 2019

I don't think consumer have anything to "implement" here, more than just using the field internally when appropriate. Nothing to change in the consumer application.

@evansiroky
Copy link
Contributor

+1 from IBI Group

@heidiguenin
Copy link
Contributor

Sorry, folks, to have to do this, but we're going to re-open the vote. Since it closed on a holiday in the US, and we still need a producer to chime in, we're giving it another go and keeping it open an extra day.

I hereby call a vote on this proposal. Voting will be open for 7 full days, until 11:59PM UTC on Monday, December 9th.

Please vote for or against the proposal to add the feed_contact_email field, and include the organization for which you are voting in your comment.

@madupras
Copy link
Contributor

madupras commented Dec 3, 2019

+1 from PBSC

@heidiguenin
Copy link
Contributor

@MuteQ @evansiroky @kanagy Would you all mind voting again now that we had to re-open the vote? Thank you!

@MuteQ
Copy link

MuteQ commented Dec 4, 2019

+1 from Transit

@evansiroky
Copy link
Contributor

+1 from IBI Group

@johnpena
Copy link

johnpena commented Dec 4, 2019

+1 from Lime

@quicklywilliam
Copy link

+1 Ride Report

@kanagy
Copy link

kanagy commented Dec 5, 2019

+1 Google Maps

@charlesjump
Copy link

+1 JUMP

@mdwestervelt
Copy link

+1 Bird

@antrim
Copy link
Contributor

antrim commented Jan 3, 2020

The vote has passed!

4 votes in favor from producers:

  • PBSC
  • Lime
  • JUMP
  • Bird

4 votes in favor from consumers:

  • Transit
  • IBI Group
  • Ride Report
  • Google Maps

@antrim antrim merged commit 0b90f89 into MobilityData:master Jan 3, 2020
@antrim
Copy link
Contributor

antrim commented Jan 3, 2020

Are there any GBFS feeds that are supplying this field? I have gone ahead and merged this, expecting GBFS feeds to provide this field soon. I expect we'll need to be more rigorous about waiting for producer/consumer implementations before a release in the future, but right now GBFS in catch up mode.

@antrim antrim added the v1.1 Candidate change for GBFS v1.1 label Jan 3, 2020
@heidiguenin
Copy link
Contributor

We'd love to make this an official part of the spec, but first we need to see this change being implemented. Could you comment here if your organization has implemented this?

@evansiroky
Copy link
Contributor

We at IBI Group may not imminently implement code to ingest this, but will definitely manually inspect feeds for this data if we need to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gbfs.md v1.1 Candidate change for GBFS v1.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.