Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes vehicle capacity at stations consistent between station_information and status #547

Merged
merged 12 commits into from
Nov 2, 2023

Conversation

cmonagle
Copy link
Contributor

@cmonagle cmonagle commented Sep 27, 2023

Note: If your PR is to add, remove, or correct a system in systems.csv, please delete this template.

If you are new to the specification, please introduce yourself (name and organization/link to GBFS). It’s helpful to know who we're chatting with!

👋 Cameron at Transit (app)

What problem does your proposal solve? Please begin with the relevant issue number. If there is no existing issue, please also describe alternative solutions you have considered.

Currently, we treat station capacity differently in station_status and station_information. In station_status, we have the spaces (docks or areas), with the count (how many docks/how much space), and the vehicle types that can use those spaces.

In station_information, it's the inverse: We include every vehicle type and the maximum number of spaces they can use.

Because they can overlap in station_information (ie: the count may exceed the total capacity), but not in station_status, it's hard to determine for sure what percentage of docks are available for a specific vehicle.

What is the proposal?

This PR makes station_information follow the same format as station status: communicate the number of places (or areas) in total, and the vehicles that can be docked or left there.

Is this a breaking change?

  • Yes
  • No
  • Unsure

Which files are affected by this change?

station_information.json

@cmonagle cmonagle marked this pull request as ready for review September 27, 2023 20:38
@cmonagle cmonagle changed the title makes vehicle capacity at stations consistent Makes vehicle capacity at stations consistent between station_information and status Sep 27, 2023
@richfab richfab added proposal:breaking gbfs.md v3.0-RC2 Candidate change for GBFS 3.0 (Major release) - 2nd pass labels Sep 28, 2023
@josee-sabourin
Copy link
Contributor

I hereby call a vote on this proposal. Voting will be open for 10 full calendar days until 11:59PM UTC on Friday, October 27th.
Please vote for or against the proposal, and include the organization for which you are voting in your comment.
Please note if you can commit to implementing the proposal.

gbfs.md Outdated Show resolved Hide resolved
@PierrickP
Copy link

fluctuo: +1

@futuretap
Copy link
Contributor

+1 from Where To?

gbfs.md Outdated Show resolved Hide resolved
@testower
Copy link
Contributor

+1 From Entur for the proposal itself, but I had a question about "should"

Copy link
Contributor

@richfab richfab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you all for the detailed comments 💯

gbfs.md Outdated Show resolved Hide resolved
gbfs.md Outdated Show resolved Hide resolved
gbfs.md Outdated Show resolved Hide resolved
gbfs.md Outdated Show resolved Hide resolved
@richfab richfab self-requested a review October 25, 2023 15:54
@josee-sabourin
Copy link
Contributor

Voting on this PR closes in 2 calendar days. Please vote for or against the proposal, and include the organization for which you are voting in your comment. Please note if you can commit to implementing the proposal.

cmonagle and others added 3 commits October 25, 2023 16:10
Co-authored-by: Fabien Richard-Allouard <[email protected]>
Co-authored-by: Fabien Richard-Allouard <[email protected]>
gbfs.md Outdated Show resolved Hide resolved
@simonsolnes
Copy link

Vote for

@josee-sabourin
Copy link
Contributor

This vote has now closed, and it passes! There was a lot of discussion during the vote about SHOULD vs. MUST. This vote will pass using SHOULD. A new proposal and vote will need to be had in order to include a MUST.

Votes in favor:
fluctuo (consumer)
Whereto.app (consumer)
Entur (consumer)
Hyre (consumer)

There were no votes against.

This change will be added to v3.0-RC2, which will be released in the coming weeks.

gbfs.md Outdated Show resolved Hide resolved
gbfs.md Outdated Show resolved Hide resolved
gbfs.md Outdated Show resolved Hide resolved
Copy link
Contributor

@richfab richfab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gbfs.md Outdated Show resolved Hide resolved
gbfs.md Outdated Show resolved Hide resolved
gbfs.md Outdated Show resolved Hide resolved
@richfab richfab merged commit 7fb21d3 into MobilityData:master Nov 2, 2023
1 check passed
@richfab
Copy link
Contributor

richfab commented Jan 24, 2024

For reference, this PR is an additional change to #384 and #407 which also changed the name and structure of vehicle_docks_capacity and vehicle_types_capacity in station_information.json.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gbfs.md v3.0-RC2 Candidate change for GBFS 3.0 (Major release) - 2nd pass Vote Passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants