-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 1504 add new error if a gtfs dataset has gtfs files in sub folders #1535
feat: 1504 add new error if a gtfs dataset has gtfs files in sub folders #1535
Conversation
fix broken test format code
change non-static noticeContainer to static
format code
format code
✅ Rule acceptance tests passed. |
I tested with a few feeds from Chaimaa's report, and it looks like the error is happening in the right cases:
My only suggestion would be to make the Notice code description and message clearer: Replace |
…tfs-files-in-sub-folders
✅ Rule acceptance tests passed. |
core/src/main/java/org/mobilitydata/gtfsvalidator/input/GtfsInput.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/mobilitydata/gtfsvalidator/input/GtfsInput.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/mobilitydata/gtfsvalidator/input/GtfsInput.java
Outdated
Show resolved
Hide resolved
core/src/test/java/org/mobilitydata/gtfsvalidator/input/GtfsInputTest.java
Outdated
Show resolved
Hide resolved
main/src/main/java/org/mobilitydata/gtfsvalidator/runner/ValidationRunner.java
Show resolved
Hide resolved
This contribution does not follow the conventions set by the Google Java style guide. Please run the following command line at the root of the project to fix formatting errors: |
This contribution does not follow the conventions set by the Google Java style guide. Please run the following command line at the root of the project to fix formatting errors: |
This contribution does not follow the conventions set by the Google Java style guide. Please run the following command line at the root of the project to fix formatting errors: |
✅ Rule acceptance tests passed. |
✅ Rule acceptance tests passed. |
✅ Rule acceptance tests passed. |
✅ Rule acceptance tests passed. |
Summary:
Closes #1504
Expected behavior:
The screenshot shows that the validator generates a invalid_input_files_in_subfolder notice if the zip file contains a subfolder that contains gtfs files.
Please make sure these boxes are checked before submitting your pull request - thanks!
gradle test
to make sure you didn't break anything