Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 1504 add new error if a gtfs dataset has gtfs files in sub folders #1535

Merged

Conversation

qcdyx
Copy link
Contributor

@qcdyx qcdyx commented Jul 17, 2023

Summary:

Closes #1504

Expected behavior:

The screenshot shows that the validator generates a invalid_input_files_in_subfolder notice if the zip file contains a subfolder that contains gtfs files.

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with gradle test to make sure you didn't break anything
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)
Screenshot 2023-07-14 at 11 56 37 AM

@qcdyx qcdyx linked an issue Jul 17, 2023 that may be closed by this pull request
@qcdyx qcdyx changed the title 1504 add new error if a gtfs dataset has gtfs files in sub folders feat: 1504 add new error if a gtfs dataset has gtfs files in sub folders Jul 17, 2023
@github-actions
Copy link
Contributor

✅ Rule acceptance tests passed.
New Errors: 9 out of 1439 datasets (~1%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1439 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1439 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1439 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1439 sources (~0 %) are corrupted.
Commit: f809966
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

@emmambd
Copy link
Contributor

emmambd commented Jul 19, 2023

I tested with a few feeds from Chaimaa's report, and it looks like the error is happening in the right cases:

  • Error does occur in cases where there's a GTFS file in a subfolder
  • No error where there's a subfolder with files unrelated to GTFS

My only suggestion would be to make the Notice code description and message clearer:

Replace Zip files containing Gtfs files in a subfolder are invalid with At least 1 GTFS file is in a subfolder. All GTFS files must reside at the root level directly.

@emmambd emmambd self-requested a review July 19, 2023 14:14
@qcdyx
Copy link
Contributor Author

qcdyx commented Jul 20, 2023

@emmambd
image

@qcdyx qcdyx requested a review from jcpitre July 20, 2023 14:03
@github-actions
Copy link
Contributor

✅ Rule acceptance tests passed.
New Errors: 9 out of 1439 datasets (~1%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1439 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1439 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1439 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1439 sources (~0 %) are corrupted.
Commit: 98a73c8
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

@github-actions
Copy link
Contributor

This contribution does not follow the conventions set by the Google Java style guide. Please run the following command line at the root of the project to fix formatting errors: ./gradlew goJF.

@github-actions
Copy link
Contributor

This contribution does not follow the conventions set by the Google Java style guide. Please run the following command line at the root of the project to fix formatting errors: ./gradlew goJF.

@github-actions
Copy link
Contributor

This contribution does not follow the conventions set by the Google Java style guide. Please run the following command line at the root of the project to fix formatting errors: ./gradlew goJF.

@github-actions
Copy link
Contributor

✅ Rule acceptance tests passed.
New Errors: 9 out of 1439 datasets (~1%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1439 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1439 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1439 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1439 sources (~0 %) are corrupted.
Commit: 9f506b9
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

@github-actions
Copy link
Contributor

✅ Rule acceptance tests passed.
New Errors: 9 out of 1439 datasets (~1%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1439 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1439 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1439 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1439 sources (~0 %) are corrupted.
Commit: 8692fdc
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

@github-actions
Copy link
Contributor

✅ Rule acceptance tests passed.
New Errors: 9 out of 1439 datasets (~1%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1439 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1439 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1439 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1439 sources (~0 %) are corrupted.
Commit: 682b982
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

@github-actions
Copy link
Contributor

✅ Rule acceptance tests passed.
New Errors: 9 out of 1439 datasets (~1%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1439 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1439 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1439 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1439 sources (~0 %) are corrupted.
Commit: 47d2024
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

@qcdyx qcdyx merged commit 7bfbe59 into master Jul 25, 2023
333 checks passed
@qcdyx qcdyx deleted the 1504-add-new-error-if-a-gtfs-dataset-has-gtfs-files-in-sub-folders branch July 25, 2023 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add new ERROR if a GTFS dataset has GTFS files in sub-folders
4 participants