Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reformatted doc using HTML table format #1669

Conversation

qcdyx
Copy link
Contributor

@qcdyx qcdyx commented Feb 12, 2024

Summary:

Closes #1624
Expected behavior:
image

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with gradle test to make sure you didn't break anything
  • Add or update any needed documentation to the repo
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

Copy link
Contributor

This contribution does not follow the conventions set by the Google Java style guide. Please run the following command line at the root of the project to fix formatting errors: ./gradlew goJF.

Copy link
Contributor

@emmambd emmambd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On a QA side, looks good to me! Opened the report and the markdown is formatted correctly now.

Copy link
Contributor

✅ Rule acceptance tests passed.
New Errors: 0 out of 1484 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1484 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1484 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1484 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
2 out of 1486 sources (~0 %) are corrupted.
Corrupted sources:
at-wien-wiener-lokalbahnen-wlb-gtfs-648
ca-ontario-transit-windsor-gtfs-720
Commit: ec80082
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

Copy link
Contributor

@jcpitre jcpitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

This contribution does not follow the conventions set by the Google Java style guide. Please run the following command line at the root of the project to fix formatting errors: ./gradlew goJF.

…contains_short_name-description-renders-on-the-html-report
@qcdyx qcdyx merged commit 69b948e into master Feb 14, 2024
332 checks passed
@qcdyx qcdyx deleted the 1624-problem-with-how-the-route_long_name_contains_short_name-description-renders-on-the-html-report branch February 14, 2024 14:47
Copy link
Contributor

✅ Rule acceptance tests passed.
New Errors: 0 out of 1485 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1485 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1485 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1485 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
1 out of 1486 sources (~0 %) are corrupted.
Corrupted sources:
us-colorado-san-miguel-authority-for-regional-transportation-smart-gtfs-811
Commit: 701be27
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem with how the route_long_name_contains_short_name description renders on the HTML report
3 participants