Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add skip version check to the master build #1684

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

davidgamez
Copy link
Member

@davidgamez davidgamez commented Mar 4, 2024

Summary:

After #1683, master build jar supports --skip_validator_update parameter. This PR adds the parameter to the master build jar execution for acceptance tests and end-to-end tests.

Completes #1668.

Expected behavior:

Acceptance tests and end-to-end test skips versions checks.

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with gradle test to make sure you didn't break anything
  • Add or update any needed documentation to the repo
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

@emmambd emmambd linked an issue Mar 4, 2024 that may be closed by this pull request
@davidgamez davidgamez changed the title add skip version check to the master build chore: add skip version check to the master build Mar 4, 2024
Copy link
Contributor

github-actions bot commented Mar 4, 2024

✅ Rule acceptance tests passed.
New Errors: 0 out of 1511 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1511 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1511 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1511 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1511 sources (~0 %) are corrupted.
Commit: 3f4fd72
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

@davidgamez davidgamez merged commit 288a1f3 into master Mar 4, 2024
333 of 334 checks passed
@davidgamez davidgamez deleted the chore/ignore-validator-version-master branch March 4, 2024 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filter out acceptance tests from validator usage report
2 participants