-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: replace GTFS Components language to GTFS features #1696
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cka-y Flagging that this features change doesn't include the components list and the deprecated notation in the JSON report like the issue described, BUT given that we're implementing another breaking change in this release already, it seems simpler just to tell users that need to make these modifications in this release rather than providing a transition period. I approve.
✅ Rule acceptance tests passed. |
✅ Rule acceptance tests passed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
✅ Rule acceptance tests passed. |
Summary:
Closes #1685
Modification to the "GTFS Components" label and replace it with "GTFS Features" so it's harmonized across the Mobility Database and gtfs.org
Expected behavior:
HTML Report
JSON report example
Please make sure these boxes are checked before submitting your pull request - thanks!
gradle test
to make sure you didn't break anything