Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document act usage to run GitHub action locally #453

Merged
6 commits merged into from
Oct 26, 2020
Merged

Conversation

ghost
Copy link

@ghost ghost commented Oct 24, 2020

closes #431

Summary:

This PR updates the documentation to describe how to run the end to end workflow locally in Docker via the act project
https://github.com/nektos/act

Expected behavior:

Syncing the latest version of master and passing the command act -j run-on-data
Now works fine with the validator running on all datasets until the persist artifact steps...
image

.. which is a known issue of act
nektos/act#329

The files in question can be manually collected inside the container.
Datasets .zip files are present as well as validation reports .json in the output folder
image

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with gradle test to make sure you didn't break anything
  • Format the title like "Fix #<issue_number> - " (for example - "Fix Bug: Running using documented Docker documentation fails #1111 - Check for null value before using field")
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

@ghost ghost requested a review from lionel-nj October 24, 2020 06:23
@ghost ghost self-assigned this Oct 24, 2020
@ghost ghost changed the title Run GitHub action locally Document act usage to run GitHub action locally Oct 24, 2020
@ghost ghost marked this pull request as ready for review October 26, 2020 12:58
Copy link
Contributor

@lionel-nj lionel-nj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! A few comments in-line though.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@ghost ghost merged commit dbc1a31 into master Oct 26, 2020
@ghost ghost deleted the local-github-action branch October 26, 2020 18:27
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REQUEST] Study possibility to run GitHub actions locally
1 participant