We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build environment: Linux Target device: ESP32
Description The SPI implementation for ESP incorrectly defaults the select pin active state to 1, see https://github.com/Moddable-OpenSource/moddable/blob/public/modules/io/spi/esp/spi.c#L66 According to ECMA-419: "active: The value to write to the select pin when the SPI instance is active. Must be 1 or 0. This property is optional and defaults to 0."
The text was updated successfully, but these errors were encountered:
Thanks for the report.
The SPI implementation for ESP incorrectly defaults the select pin active state to 1
True. The fix is trivial but updating callers that depend on the current implementation is some work.
Sorry, something went wrong.
ECMA-419 conformance: SPI active defaults to 0 #1051
2b4170c
Fixed with the March 1 commit noted above.
No branches or pull requests
Build environment: Linux
Target device: ESP32
Description
The SPI implementation for ESP incorrectly defaults the select pin active state to 1, see https://github.com/Moddable-OpenSource/moddable/blob/public/modules/io/spi/esp/spi.c#L66
According to ECMA-419: "active: The value to write to the select pin when the SPI instance is active. Must be 1 or 0. This property is optional and defaults to 0."
The text was updated successfully, but these errors were encountered: