-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sockets on Windows simulator do not close #1058
Comments
Thank you for the detailed report. It could be a few days before we can look into this in detail. However, in reviewing the implementation of modSocket.c for Windows, it looks like the callback ignores all message when an error is set. That seems to have the potential to suppress the delivery of In addition, it looks like that same check would prevent notifications of failed connections. For example, when it isn't immediately obvious why all requests but the first fail. But, let's sort of the |
Thank you for your response. I have tested through |
Thanks for the update. We'll take a deeper look. |
I have been testing through trial-and-error and across different versions, and I found that version |
Thank you for the exhaustive investigation here--I really appreciate it. I'll take those notes and get back to this today to see if we can close this out. Thanks! |
@jethrowharton Thank you for your patience on this. I have a draft fix for this problem that is working well in my initial tests. I'm hoping to get some review of the changes by the rest of the team and then I'll get a final fix out in our next update. |
Thank you for letting me know. I'm excited for the fix. |
… the correct Window handle (#1058)
…ts 8e571e and replaces it with a new implementation)
@jethrowharton This fix is now live. Please update from GitHub and give it a try. Let me know how it goes. As Peter rightly noted, there are also some issues with error handling in the Windows socket code. I don't believe that's directly related to what you were seeing here, but it is definitely in need of a fix. I'll have those in shortly. |
I have tested and it works properly. Thank you for the quick fix! Also, now I am able to use |
Great! I'm glad to hear that everything is looking good there. The other topic discussed in this thread was addressed with 4188333. If everything is looking good, shall we close this out? |
Closing. |
Build environment: Windows 10
Target device: desktop simulator
Description
Sockets do not close on Windows xsbug simulator, causing sockets to increase without resolving. Only the first request is successful, all other requests are blocked.
Steps to Reproduce
mcconfig -d -m -p win
Expected behavior
Socket should close and new request should complete successfully.
Other information
We checked the Windows socket module (modSocket.c) and we added traces to the file, and confirmed that
FD_CLOSE
was never called. However, the sockets work as intended on the Mac simulator.The text was updated successfully, but these errors were encountered: