Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows makefile Syntax Error #1078

Closed
NW-Lab opened this issue Apr 5, 2023 · 4 comments
Closed

Windows makefile Syntax Error #1078

NW-Lab opened this issue Apr 5, 2023 · 4 comments

Comments

@NW-Lab
Copy link
Contributor

NW-Lab commented Apr 5, 2023

Build environment: Windows (Node-Red-MCU Plugin)
Target device: m5stick_cplus

Description
Build stops with a syntax error.

Steps to Reproduce
build.bat generated by plugin.

CALL "C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Auxiliary\Build\vcvars32.bat"
pushd %IDF_PATH%
CALL "C:\Espressif\idf_cmd_init.bat"
popd
@echo mcconfig -d -x localhost:5004 -m -p esp32/m5stick_cplus -r 180
mcconfig -d -x localhost:5004 -m -p esp32/m5stick_cplus -r 180
  1. See error
    image

Other information
Looking at the makefile, it looks like C_FLAGS_SUBPLATFORM is not defined.
@phoddie
Copy link
Collaborator

phoddie commented Apr 5, 2023

Oops. Thanks for catching that so quickly. We'll take a look.

mkellner pushed a commit that referenced this issue Apr 5, 2023
@andycarle
fix Windows build (#1078)
8738fa1
@phoddie
Copy link
Collaborator

phoddie commented Apr 5, 2023

Should be better now. Would you please confirm?

@NW-Lab
Copy link
Contributor Author

NW-Lab commented Apr 5, 2023

Now it works.
thank you.

@NW-Lab NW-Lab closed this as completed Apr 5, 2023
@phoddie
Copy link
Collaborator

phoddie commented Apr 5, 2023

Excellent. Sorry for the trouble.

mkellner pushed a commit that referenced this issue Aug 11, 2023
@andycarle @mkellner
fix Windows build (#1078)
e656564
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@phoddie @NW-Lab