Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving statistics calculations to hstats() #61

Merged
merged 4 commits into from
Sep 18, 2023
Merged

Moving statistics calculations to hstats() #61

merged 4 commits into from
Sep 18, 2023

Conversation

mayer79
Copy link
Collaborator

@mayer79 mayer79 commented Sep 17, 2023

The aim of this PR is to move the calculation of H-statistics into hstats(). This is different from the current implementation where the functions h2(), ... would take an "hstats" object and do the cheap calculations themselfes. These functions should only care about postprocessing, like "take square?", "normalize", etc.

@codecov-commenter
Copy link

codecov-commenter commented Sep 17, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01% ⚠️

Comparison is base (d7001dd) 97.81% compared to head (5a5faa7) 97.80%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #61      +/-   ##
==========================================
- Coverage   97.81%   97.80%   -0.01%     
==========================================
  Files          14       14              
  Lines         732      730       -2     
==========================================
- Hits          716      714       -2     
  Misses         16       16              
Files Changed Coverage Δ
R/H2.R 91.66% <100.00%> (+2.77%) ⬆️
R/H2_overall.R 93.75% <100.00%> (+0.41%) ⬆️
R/H2_pairwise.R 95.45% <100.00%> (-0.20%) ⬇️
R/H2_threeway.R 95.83% <100.00%> (-0.17%) ⬇️
R/hstats.R 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mayer79 mayer79 merged commit 278845b into main Sep 18, 2023
7 checks passed
@mayer79 mayer79 deleted the move_statistics branch September 18, 2023 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants