Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rowsum warning #84

Merged
merged 2 commits into from
Oct 21, 2023
Merged

Rowsum warning #84

merged 2 commits into from
Oct 21, 2023

Conversation

mayer79
Copy link
Collaborator

@mayer79 mayer79 commented Oct 21, 2023

Fix the repeated warnings from rowsum() when the grouping variable has missings.

Exception: average_loss(). There, a missing BY variable will still produce the warning, which seems ok.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (aba883f) 96.55% compared to head (894ce95) 96.55%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #84   +/-   ##
=======================================
  Coverage   96.55%   96.55%           
=======================================
  Files          18       18           
  Lines         957      959    +2     
=======================================
+ Hits          924      926    +2     
  Misses         33       33           
Files Coverage Δ
R/pd_raw.R 98.07% <100.00%> (+0.07%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mayer79 mayer79 merged commit 7a97c03 into main Oct 21, 2023
7 checks passed
@mayer79 mayer79 deleted the rowsum_warning branch October 21, 2023 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants