-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Best way to suppress duplicate alerts #129
Labels
Comments
Sounds good thanks Mohammad. Just to be clear your solution in #123 is
basically to use a helper function that acts external to alerting itself.
I think ideally this would be baked into the alertify function itself. I
dont imagine it should be too tough to do. We just need to have a hook that
is called before the .success(), .error(), etc methods are called. The hook
would run any necessary logic and then delegate to the original function
being called. What do you think?
…On Sun, Nov 27, 2016, 3:30 PM Mohammad Younes ***@***.***> wrote:
Hi,
For now, I would say externally (Same answer as in #123
<#123>), Which I kept
open to consider such options in the next version.
Please update #123
<#123> with the use
cases you have.
Thanks!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#129 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACmqcQUcXt-sjSlfjbeHTaVVFiez3eVbks5rCaH8gaJpZM4K9JAy>
.
|
I don't see much difference between using hooks vs an external wrapper. I was thinking of something that is configurable, where you don't have to write any logic. Anyway, PRs are very welcome :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hey there,
I was just wondering what the best way to suppress duplicate toaster messages would be. Ideally toasts with the same text could be collapsed/filtered out so only 1 is shown instead of many.
Thanks!
The text was updated successfully, but these errors were encountered: