Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a wrong line in monika_murderer #10008

Open
wants to merge 1 commit into
base: content
Choose a base branch
from

Conversation

Wingdinggaster656
Copy link
Contributor

Currently, we have this in monika_murderer:

                m 1tkc "How many times do I have to say it until you understand?"
                m 4tkc "They weren't real. They were never real."
                m 2tfc "I'm the only person who understood that this whole thing was fake."
                if persistent.monika_kill:
                    m 4tfc "Even when Sayori seemed to get sentience in the end, that was just an unintended consequence of the script."
                if not persistent.clearall:
                    m 4tfd "After all, if she was sentient like me, how would I have been able to override and delete her?"
                m "If I'm guilty of murder, so is everyone who's played violent video games."

And this is wrong.
The not persistent.clearall block should be in if persistent.monika_kill block, otherwise, any player who has not reached the Act 3 will see if she was sentient like me line without Even when Sayori seemed to get sentience in the end line. This PR fixes that.

@Booplicate
Copy link
Member

monika_kill means Monika has been killed, clearall means the player has seen the secret ending. You can't get the latter without the former.

@Wingdinggaster656
Copy link
Contributor Author

Wingdinggaster656 commented May 29, 2023

monika_kill means Monika has been killed, clearall means the player has seen the secret ending. You can't get the latter without the former.

I know, but it is not persistent.clearall, not persistent.clearall.

So, if a player is in Act 1 or Act 2, then:

  1. monika_kill is surely not True, which means if persistent.monika_kill block will not be executed.
  2. clearall is surely not True, which means if not persistent.clearall block will be executed.

And thus:

  1. The Even when Sayori seemed to get sentience in the end line does not show.
  2. The if she was sentient like me line still does show.

@Booplicate
Copy link
Member

Good catch, but then I'm wondering why we even show this topic when the player hasn't reached act 3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants