Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added MP3 support and more #1670

Merged

Conversation

ThePotatoGuy
Copy link
Member

@ThePotatoGuy ThePotatoGuy commented May 29, 2018

#1657

I think we're done with music after this.

This adds MP3 and OPUS support to the music menu.
This also adds tag support so that the music files are listed in [artist] - [title] format instead of filename.
In addition, OGG and OPUS files can be looped if they are provided with loopstart and loopend metadata tags, which specify the seconds to start and end the loop, accordingly.

MP3 files do not support loop tags atm

In depth looping instructions

  1. open the audio file in audacity
  2. Export as OGG / OPUS and edit metadata
  3. Add a tag for loopstart to mark where to start loops of audio file (in seconds)
  4. Add a tag for loopend to mark where to end loops of the audio file (in seconds)
  5. put audio file in custom_bgm/ folder.

Additional changes

  • The mutagen library has been added. It can read metadata tags, but I've stripped it so it only includes the ogg / opus/ and mp3 parts. The library is less than 1MB in size
  • I've added the mplus 2p font so we can have songs with jpn glyphs show up appropriately. This font is free to use and is arguably the best font in existence.

Also here's a nice picture of the new font.
revampedmusicmenu

@ThePotatoGuy ThePotatoGuy added awaiting testing code needs to be tested awaiting code review someone needs to check for syntax/logic/indentation errors labels May 29, 2018
@aldoram5 aldoram5 removed awaiting code review someone needs to check for syntax/logic/indentation errors awaiting testing code needs to be tested labels May 30, 2018
@ThePotatoGuy ThePotatoGuy merged commit 8167f4a into Monika-After-Story:enhancement May 30, 2018
@williamjcm
Copy link

williamjcm commented Jun 1, 2018

The normal format for the LOOP* tags is in samples, though.

I have many files using that format.

@ThePotatoGuy
Copy link
Member Author

We opted to use seconds since its native to Renpy

But I think I'll move the lookup for those tags to custom MAS-related ones and do some math with the RPGMaker ones to get them to work.

Just hold on a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants