-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added new type of scrollable menu #5803
Added new type of scrollable menu #5803
Conversation
Before, passing in an area with width less than 560 px, cut off buttons tips Also we forgot to add text_align to the style
maybe not Co-Authored-By: multimokia <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you make a dev label for testing this menu.
Additionally, keep the branch names to a reasonable length next time.
Co-authored-by: ThePotatoGuy <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a better color scheme for selected/unselected is to use the same one that the selectors (and piano config) use - standard pink for not selected, peachy for selected. Especially since we use gray everywhere else to signify that an option is disabled/uninteractable.
But I still think the disabled style looks better here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these look beautiful, great work
This adds a scrollable menu with checkboxes. In theory this should make code more clear by removing label loops that were used for
mas_gen_scrollable_menu
. Instead of returning a value, buttons switch it betweenTrue
/False
. To close the menu the user needs to click the return button. It'll also return a dict with buttons keys corresponding to their values.I used the existing styles for unchecked buttons. If you think they look confusing, we can add a new style for those buttons.
Also while we're in styles, I fixed that old bug which didn't allow to use narrow scrollable menus (<560 px).
Testing
True
values, no crashes, buttons checks/unchecks)mas_gen_scrollable_menu
still look good, and bothmas_gen_scrollable_menu
andmas_check_scrollable_menu
support menus of any width.