Implement dmx input with rdm support #64

arneboe · 2023-08-14T12:52:19Z

Currently I am maintaining an old fork of WLED that supports dmx input with rdm using the esp_dmx library.
I would like to get rid of that fork and instead use MoonModules with as little changes as possible.
My usecase is having dmx input with rdm and dmx output work at the same time (using two max495 on port 1 and 2).

I worked through @netmindz dmx input and dmx output branches trying to get them to work and adapt them to my usecase.

Juggling those branches was kinda challenging for me because they are tracking and old commit of WLED and an old version of esp_dmx and dmx input and output where kinda entangled. Thus I decided to clean it up a bit.
That kinda got out of hand and here we are. (I hope you don't mind ❤️ )

The goals for this PR are:

Have completely different code paths for dmx input and dmx output
Use esp_dmx for dmx input on esp32
Support setting the dmx input address via rdm
Support setting the dmx input personality via rdm
Support dmx input rdm identify requests
Some cleanup and correct error handling

edit: From my point of view this PR is ready to merge. It is working as intended in my test cases.

netmindz · 2023-08-14T18:49:34Z

Sounds like great goals. Let me know if there are any specific questions you have while trying to complete this PR

arneboe · 2023-08-17T13:59:42Z

I am having trouble with a crash that happens when dmx is received while the wifi hotspot is being activated.
I am getting the "Cache disabled but cached memory region accessed" panic.
My guess is, that activating wifi disables the cache.
But the dmx driver has been placed in IRAM so this shouldn't happen?

When I wait until wifi has been activated before connecting dmx, it works fine.
But this is not a feasible solution because devices are connected to the dmx bus before they are turned on :D

Edit: This can be circumvented by disabling the dmx driver inside WLED::initConnection().

Edit: This also happens when accessing the web interface. I have no idea where the entrypoint for the webinterface code is. I.e. a function that is always called before the cache is disabled.

arneboe · 2023-08-17T14:44:04Z

Calling dmx_receive with zero timeout does never receive any data.
I am unsure if this is a bug or intended behavior.
I created an issue someweisguy/esp_dmx#87 on esp_dmx to resolve that question.

If this is intended behavior, I will probably have to move the dmx_receive code over into its own task. Do you see any problems with that? And should I pin it to core 0 or 1? Afaik all the arduino stuff runs on core 1, so maybe pinning it to core 0 is a good idea?

arneboe · 2023-08-18T14:42:41Z

Sounds like great goals. Let me know if there are any specific questions you have while trying to complete this PR

I have a specific question :D
If the user changes the dmx start address using rdm, how can I store it permanently? Probably I have to use the same code path that the web interface is using. But i cannot figure out how the web interface saves data.
edit: found it ;)

softhack007 · 2023-08-22T21:54:56Z

arneboe force-pushed the dmx_input branch

@arneboe please try to avoid force-pushing. It may cause lots of weird behaviour on github later.

If you need to copy single commits from one branch to another, it's better to use cherry-picking. It even works between different repositories.

https://docs.github.com/en/desktop/contributing-and-collaborating-using-github-desktop/managing-commits/cherry-picking-a-commit-in-github-desktop

arneboe · 2023-08-23T11:20:43Z

arneboe force-pushed the dmx_input branch

@arneboe please try to avoid force-pushing. It may cause lots of weird behaviour on github later.

If you need to copy single commits from one branch to another, it's better to use cherry-picking. It even works between different repositories.

https://docs.github.com/en/desktop/contributing-and-collaborating-using-github-desktop/managing-commits/cherry-picking-a-commit-in-github-desktop

I am force pushing for several reasons:

rebasing this branch on top of changes that have happened in mdev since I forked.
Modifying existing commits because I forgot to push things that belong to that commit.

Both of those shouldn't cause problems when merging later. Rebasing makes the merge easier and modifying my own commits shouldn't matter because they do not exist on the main branch.

I agree, that copying single commits from somewhere should be done by cherry picking. But that is not what I am doing here.

arneboe · 2023-08-23T11:26:17Z

The dmx input side is more or less done and I would appreciate some reviews :-)
It is tested and working using a Botex RDM/DMX tester. But that is just one test. Maybe someone else could test it aswell.

However, it relies on changes that I made to esp_dmx that are stil under review. Thus for now this PR is tracking my fork of esp_dmx until the following PRs are merged:
someweisguy/esp_dmx#90
someweisguy/esp_dmx#92
someweisguy/esp_dmx#93

arneboe · 2023-08-23T13:48:52Z

For readability reasons I would like to implement dmx output in a different PR.
Otherwise this gets really hard to review.
Also, I am not sure if there is any benefit in using esp_dmx for the dmx output if the sparkfun lib works just fine? What do you think? @netmindz @softhack007

arneboe · 2023-08-25T19:01:37Z

I had to put the dmx receiver into its own task on core 0.
Otherwise it was not able to respond to rdm requests in time (there is only a few micros to respond due to how rdm works).
I am not sure if this breaks anything else?.It works for me :D

netmindz · 2023-08-27T09:23:09Z

Sorry for not replying, having some health issues. Should hopefully be able to look at soon

arneboe · 2023-09-03T13:57:00Z

Sorry for not replying, having some health issues. Should hopefully be able to look at soon

No need to apoligize :) Take your time!

This is the first step in supporting both dmx input and dmx output on different pins.

This greatly improves readability because it gets rid of most of the ifdefs.

Some minor cleanup changes

No longer needed because missing ISR_ATTR have been added to esp_dmx.

This was necessary because otherwise it is not able to respond to rdm in time.

arneboe · 2023-09-24T11:31:32Z

All required changes have been merged into esp_dmx upstream. Thus I removed my custom branch of esp_dmx.
I rebased this branch on top of mdev again to keep it easy to merge.

platformio.ini

tools/cdata.js

wled00/dmx_input.cpp

netmindz · 2023-09-30T10:32:17Z

wled00/dmx_input.cpp

+    return;
+  }
+
+  if (rxPin > 0 && enPin > 0 && txPin > 0)


Enable is actually optional with the newer RS485 adapters

The esp_dmx library requires an en pin. The user can set any unused gpio if their rs485 adapter does not require an en pin. But some pin has to be set.

Thought I was passing 0 or -1 before

(when not required)

I poked around a bit in esp_dmx and it looks like the pin has to fulfill GPIO_IS_VALID_OUTPUT_GPIO. Otherwise esp_dmx will fail to initialize.

wled00/dmx_input.cpp

wled00/dmx_input.h

wled00/dmx_output.cpp

netmindz · 2023-09-30T10:47:14Z

Sorry it's taken so long to get back to you @arneboe

Overall I would say great contribution, you have cleaned up my initial implementation quite a bit, just a few minor issues to address

arneboe · 2023-09-30T20:55:16Z

Sorry it's taken so long to get back to you @arneboe

Overall I would say great contribution, you have cleaned up my initial implementation quite a bit, just a few minor issues to address

Thanks for the review. I ll fix everything within the next days :)

This reverts commit e3f256b.

netmindz · 2023-12-13T21:18:41Z

Sorry, I've not tested this yet @arneboe I've not got a suitable test setup at the moment. I have shared links to this on Discord and asked others to help test but I've not heard back. Can you try and get others to test too? You will also need to resolve the merge conflicts before I can merge

softhack007 · 2023-12-13T21:23:49Z

Hi guys @arneboe @netmindz,
I'm preparing for a MM release this weekend. Would it be ok for you if we merge DMX changes after the release?

netmindz · 2023-12-15T17:18:57Z

Yeah that's fine @softhack007

netmindz · 2023-12-30T18:56:51Z

Are you able to resolve the conflicts @arneboe ?

arneboe · 2024-01-16T09:23:58Z

I can try to take a look on the weekend but no promises.

netmindz · 2024-01-16T09:36:47Z

Thanks. It's really just the platformio change that matters, for the html stuff it will just be running the npm task and submitting your change

netmindz · 2024-01-16T19:10:48Z

Github let me resolve the conflict, but then doesn't give me permission to commit the result of "npm run build" @arneboe

netmindz · 2024-01-17T19:12:50Z

I've made a few tweaks, if you can merge the the MM dmx_input branch into yours, then I think we are good to then accept this PR @arneboe

arneboe changed the title ~~WIP Cleanup/implement dmx input/output~~ WIP: Cleanup/implement dmx input/output Aug 14, 2023

arneboe force-pushed the dmx_input branch 2 times, most recently from ba6f8f8 to 930506a Compare August 14, 2023 14:04

netmindz mentioned this pull request Aug 18, 2023

Calling dmx_receive with wait_ticks=0 does never return data someweisguy/esp_dmx#87

Closed

arneboe force-pushed the dmx_input branch 2 times, most recently from 8c07246 to 046128f Compare August 22, 2023 20:11

softhack007 requested review from netmindz, softhack007 and troyhacks August 22, 2023 22:00

softhack007 marked this pull request as draft August 23, 2023 10:47

arneboe changed the title ~~WIP: Cleanup/implement dmx input/output~~ WIP: Cleanup/implement dmx input Aug 23, 2023

arneboe force-pushed the dmx_input branch from 9169b8e to d54b3af Compare August 24, 2023 19:31

arneboe force-pushed the dmx_input branch from 5d20aca to dffcbe8 Compare September 3, 2023 14:35

arneboe added 6 commits September 24, 2023 13:30

Update esp_dmx dependency version to 3.1

97dcce0

rename global dmx... variables to dmxInput...

1bc6e25

This is the first step in supporting both dmx input and dmx output on different pins.

Adapt to new api of esp_dmx v3.1

5ad90e9

Move dmx_input pin allocations from wled.cpp to dmx.cpp

a516a7b

Extract dmx_input from dmx.cpp into dmx_input.cpp.

b4bbf0a

This greatly improves readability because it gets rid of most of the ifdefs.

Move globals to top of file and change scope to compile unit only.

3ee003a

Some minor cleanup changes

arneboe added 7 commits September 24, 2023 13:30

rename handleDMX() handleDMXOutput()

6efd745

rename initDmx() -> initDmxOutput()

7cccb2e

Do no longer disable dmx_input when cache is disabled.

ff2953b

No longer needed because missing ISR_ATTR have been added to esp_dmx.

Move dmx_input into its own task on core 0.

4a8d3e3

This was necessary because otherwise it is not able to respond to rdm in time.

npm run build

19dfc36

make compile after rebase

a204b83

npm run build after rebase

a5820bc

arneboe force-pushed the dmx_input branch from 8871870 to a5820bc Compare September 24, 2023 11:30

arneboe marked this pull request as ready for review September 24, 2023 11:31

arneboe changed the title ~~WIP: Cleanup/implement dmx input~~ Implement dmx input with rdm support Sep 24, 2023

switch to esp_dmx v3.1 dependency

e727121

netmindz requested changes Sep 30, 2023

View reviewed changes

arneboe added 4 commits October 22, 2023 20:22

fix: pin esp_dmx version

55c5f60

chore: adapt code style

d15b213

chore: remove outdated comments

f6c9708

Revert "Rename WLED_ENABLE_DMX to WLED_ENABLE_DMX_OUTPUT"

3b9b9f5

This reverts commit e3f256b.

Merge branch 'mdev' into dmx_input

42109fe

netmindz mentioned this pull request Jan 17, 2024

Implement dmx input with rdm support - with tweaks #111

Merged

netmindz merged commit 42109fe into MoonModules:mdev Feb 10, 2024
29 of 30 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement dmx input with rdm support #64

Implement dmx input with rdm support #64

arneboe commented Aug 14, 2023 •

edited

Loading

netmindz commented Aug 14, 2023

arneboe commented Aug 17, 2023 •

edited

Loading

arneboe commented Aug 17, 2023

arneboe commented Aug 18, 2023 •

edited

Loading

softhack007 commented Aug 22, 2023 •

edited

Loading

arneboe commented Aug 23, 2023 •

edited

Loading

arneboe commented Aug 23, 2023

arneboe commented Aug 23, 2023

arneboe commented Aug 25, 2023

netmindz commented Aug 27, 2023

arneboe commented Sep 3, 2023

arneboe commented Sep 24, 2023

netmindz Sep 30, 2023

arneboe Oct 22, 2023

netmindz Oct 22, 2023

netmindz Oct 22, 2023

arneboe Oct 22, 2023

netmindz commented Sep 30, 2023

arneboe commented Sep 30, 2023

netmindz commented Dec 13, 2023

softhack007 commented Dec 13, 2023

netmindz commented Dec 15, 2023

netmindz commented Dec 30, 2023

arneboe commented Jan 16, 2024

netmindz commented Jan 16, 2024

netmindz commented Jan 16, 2024

netmindz commented Jan 17, 2024 •

edited

Loading

Implement dmx input with rdm support #64

Implement dmx input with rdm support #64

Conversation

arneboe commented Aug 14, 2023 • edited Loading

netmindz commented Aug 14, 2023

arneboe commented Aug 17, 2023 • edited Loading

arneboe commented Aug 17, 2023

arneboe commented Aug 18, 2023 • edited Loading

softhack007 commented Aug 22, 2023 • edited Loading

arneboe commented Aug 23, 2023 • edited Loading

arneboe commented Aug 23, 2023

arneboe commented Aug 23, 2023

arneboe commented Aug 25, 2023

netmindz commented Aug 27, 2023

arneboe commented Sep 3, 2023

arneboe commented Sep 24, 2023

netmindz Sep 30, 2023

Choose a reason for hiding this comment

arneboe Oct 22, 2023

Choose a reason for hiding this comment

netmindz Oct 22, 2023

Choose a reason for hiding this comment

netmindz Oct 22, 2023

Choose a reason for hiding this comment

arneboe Oct 22, 2023

Choose a reason for hiding this comment

netmindz commented Sep 30, 2023

arneboe commented Sep 30, 2023

netmindz commented Dec 13, 2023

softhack007 commented Dec 13, 2023

netmindz commented Dec 15, 2023

netmindz commented Dec 30, 2023

arneboe commented Jan 16, 2024

netmindz commented Jan 16, 2024

netmindz commented Jan 16, 2024

netmindz commented Jan 17, 2024 • edited Loading

arneboe commented Aug 14, 2023 •

edited

Loading

arneboe commented Aug 17, 2023 •

edited

Loading

arneboe commented Aug 18, 2023 •

edited

Loading

softhack007 commented Aug 22, 2023 •

edited

Loading

arneboe commented Aug 23, 2023 •

edited

Loading

netmindz commented Jan 17, 2024 •

edited

Loading