Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blackice theme mismatch #785

Open
davidjkrause opened this issue Dec 31, 2014 · 7 comments
Open

blackice theme mismatch #785

davidjkrause opened this issue Dec 31, 2014 · 7 comments

Comments

@davidjkrause
Copy link

Was trying out the various themes that are included. There's a theme file called theme.black-ice.css, but the css in that file drops the "-", so if you include the file theme.black-ice.css, the Javascript to use later needs to be:

    theme: blackice;

This is unlike the other theme with a "-" in the title, metro-dark, where the "-" is kept in the css.

It was easiest for me to change the file name of the css to theme.blackice.css, then I can continue using templates to switch themes where the file name matches the css.

@Mottie
Copy link
Owner

Mottie commented Dec 31, 2014

Hi @davidjkrause!

I think I'll leave it as it is for now because of all the jsFiddle demos out there that link to the file.

But, thanks for the heads up! I will fix the file name in the Abelt repository (ref) so that the dash won't be an issue once this repository is replaced by that plugin.

@davidjkrause
Copy link
Author

Okay, I will keep an eye an AbeIt, looks great.

Also, I found that using "headerTemplate: {content}" doesn't kill the icons with the blackice theme, because it seems they are just background images, and nothing is clearing them out. Is that expected?

@Mottie
Copy link
Owner

Mottie commented Dec 31, 2014

The blackice theme adds a header background image. It doesn't use or do anything to the icons, so you'll need to add some extra css to hide the icons.

.tablesorter-blackice .tablesorter-header i {
  display: none;
}

In Abelt, I made all themes use the icon, and set the headerTemplate option to be {content} {icon} by default.

@lindonb
Copy link

lindonb commented Dec 31, 2014

Hi,

I’m curious, what is Abelt? Is it meant to replace tablesorter eventually?
Thanks,
lindonb

On Dec 31, 2014, at 2:19 PM, Rob G [email protected] wrote:

Hi @davidjkrause https://github.com/davidjkrause!

I think I'll leave it as it is for now because of all the jsFiddle demos out there that link to the file.

But, thanks for the heads up! I will fix the file name in the Abelt https://github.com/tablesort/Abelt repository so that the dash won't be an issue once this repository is replaced by that plugin.


Reply to this email directly or view it on GitHub #785 (comment).

@Mottie
Copy link
Owner

Mottie commented Dec 31, 2014

Hi @lindonb!

Yes.

I'm making Abelt more modular (sorting has been moved into a widget) and meant to replace my fork of tablesorter. This was done in part to avoid confusing this fork with the original tablesorter - trust me it happens a lot - and partly to make some much needed changes to the infrastructure.

Abelt is still a work-in-progress. I have a very basic version running in the Abelt repository (no online demo yet) which I have been slowly working on when I have time.

@lindonb
Copy link

lindonb commented Jan 1, 2015

Thanks @Mottie!

Your fork of tablesorter is a great program so glad to see you continuing to improve it. Hopefully the switchover won't be too painful, but anyway no pain no gain!
Regards,
lindonb

@Mottie Mottie modified the milestone: Abelt Jan 20, 2015
@Mottie
Copy link
Owner

Mottie commented Feb 21, 2015

@davidjkrause!

In the latest version (v2.20.0), I added a build process which creates a distribution folder (dist). Within the theme folder (dist/css), the black ice file is named theme.blackice.min.css.

Just one more step to building a better plugin 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants