blackice theme mismatch

[davidjkrause]

Was trying out the various themes that are included. There's a theme file called theme.black-ice.css, but the css in that file drops the "-", so if you include the file theme.black-ice.css, the Javascript to use later needs to be:

    theme: blackice;

This is unlike the other theme with a "-" in the title, metro-dark, where the "-" is kept in the css.

It was easiest for me to change the file name of the css to theme.blackice.css, then I can continue using templates to switch themes where the file name matches the css.

[Mottie]

Hi @davidjkrause!

I think I'll leave it as it is for now because of all the jsFiddle demos out there that link to the file.

But, thanks for the heads up! I will fix the file name in the Abelt repository (ref) so that the dash won't be an issue once this repository is replaced by that plugin.

[davidjkrause]

Okay, I will keep an eye an AbeIt, looks great.

Also, I found that using "headerTemplate: {content}" doesn't kill the icons with the blackice theme, because it seems they are just background images, and nothing is clearing them out. Is that expected?

[Mottie]

The blackice theme adds a header background image. It doesn't use or do anything to the icons, so you'll need to add some extra css to hide the icons.

.tablesorter-blackice .tablesorter-header i {
  display: none;
}

In Abelt, I made all themes use the icon, and set the headerTemplate option to be {content} {icon} by default.

[lindonb]

Hi,

I’m curious, what is Abelt? Is it meant to replace tablesorter eventually?
Thanks,
lindonb

On Dec 31, 2014, at 2:19 PM, Rob G [email protected] wrote:

Hi @davidjkrause https://github.com/davidjkrause!

I think I'll leave it as it is for now because of all the jsFiddle demos out there that link to the file.

But, thanks for the heads up! I will fix the file name in the Abelt https://github.com/tablesort/Abelt repository so that the dash won't be an issue once this repository is replaced by that plugin.

—
Reply to this email directly or view it on GitHub #785 (comment).

[Mottie]

Hi @lindonb!

Yes.

I'm making Abelt more modular (sorting has been moved into a widget) and meant to replace my fork of tablesorter. This was done in part to avoid confusing this fork with the original tablesorter - trust me it happens a lot - and partly to make some much needed changes to the infrastructure.

Abelt is still a work-in-progress. I have a very basic version running in the Abelt repository (no online demo yet) which I have been slowly working on when I have time.

[lindonb]

Thanks @Mottie!

Your fork of tablesorter is a great program so glad to see you continuing to improve it. Hopefully the switchover won't be too painful, but anyway no pain no gain!
Regards,
lindonb

[Mottie]

@davidjkrause!

In the latest version (v2.20.0), I added a build process which creates a distribution folder (dist). Within the theme folder (dist/css), the black ice file is named theme.blackice.min.css.

Just one more step to building a better plugin 😀