Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AMD/browserify support #786

Merged
merged 3 commits into from
Jan 4, 2015
Merged

Add AMD/browserify support #786

merged 3 commits into from
Jan 4, 2015

Conversation

mwiencek
Copy link
Contributor

@mwiencek mwiencek commented Jan 4, 2015

This adds support for AMD loaders like requirejs, as well as browserify, so that a shim config isn't needed in either case. This is pretty standard boilerplate but there are examples for most environments at https://github.com/umdjs/umd

I fixed some problems in package.json that prevented the module from working with npm/browserify. The main field (which indicates the entry file when someone does var tablesorter = require('tablesorter')) was referencing a file that doesn't exist, so I changed it to include the non-minified files and have it reference js/jquery.tablesorter.js as main. The non-minified files are more useful for development/debugging, and people using these tools already have their own minification process for deployment.

Mottie added a commit that referenced this pull request Jan 4, 2015
Add AMD/browserify support
@Mottie Mottie merged commit 430f8c5 into Mottie:master Jan 4, 2015
@Mottie
Copy link
Owner

Mottie commented Jan 4, 2015

Hi @mwiencek!

Awesome! Thanks for the help :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants