User selected columns to filter #817
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @MaksimProgr! Thanks for sharing this! I'll try it out when I get some time. I was actually asking for opinions in that issue on a good straight-forward method that makes sense. I'll rustle up some feed back from others and see what the consensus is on this method. Thanks again! |
|
I'm merged your changes in e6db1fa. I also made a few modifications, including adding a Please note that the filter widget was moved to a separate file ( Thanks again for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the issue: #747
I have done this by splitting and then moving indexed parts from anyMatchFilter to filters array. Is it an appropriate solution?