Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't update dependency #41

Open
XF-FW opened this issue Oct 27, 2023 · 5 comments · May be fixed by #64
Open

Doesn't update dependency #41

XF-FW opened this issue Oct 27, 2023 · 5 comments · May be fixed by #64

Comments

@XF-FW
Copy link

XF-FW commented Oct 27, 2023

❯ poetry new abc
❯ cd abc
❯ poetry add "ruff@^0.1.1"
❯ rg ruff
pyproject.toml
10:ruff = "^0.1.1"

poetry.lock
4:name = "ruff"
10:    {file = "ruff-0.1.3-py3-none-macosx_10_7_x86_64.whl", hash = "sha256:b46d43d51f7061652eeadb426a9e3caa1e0002470229ab2fc19de8a7b0766901"},
etc...

❯ poetry up --latest
❯ # Nothing changes
❯ rg ruff
pyproject.toml
10:ruff = "^0.1.1"

poetry.lock
4:name = "ruff"
10:    {file = "ruff-0.1.3-py3-none-macosx_10_7_x86_64.whl", hash = "sha256:b46d43d51f7061652eeadb426a9e3caa1e0002470229ab2fc19de8a7b0766901"},

❯ poetry add ruff@latest
❯ # This did change the pyproject version
❯ rg ruff
pyproject.toml
10:ruff = "^0.1.3"

poetry.lock
4:name = "ruff"
10:    {file = "ruff-0.1.3-py3-none-macosx_10_7_x86_64.whl", hash = "sha256:b46d43d51f7061652eeadb426a9e3caa1e0002470229ab2fc19de8a7b0766901"},

Hopefully this helps in tracking the issue.

Just to clarify, am I right to say:

  • After poetry up --latest the pyproject version should match the one in poetry.lock
  • Doing poetry up --latest should be the same as running poetry add package@latest for every package.

Thanks

@Ravencentric
Copy link

Having the same issue on Windows 11 with Python 3.12 and Poetry 1.7.1

@jm-glowienke
Copy link

jm-glowienke commented Nov 21, 2023

Any updates on this? For packages in the "0.x.x" range, I noticed the same behaviour, but that might be related to this PR: #26

@georgereynolds-metoffice
Copy link

georgereynolds-metoffice commented May 7, 2024

I've had this occur e.g. in my pyproject.toml I have cfn-lint as cfn-lint = "^0.83.3 but I couldn't get poetry up to grab the latest version at all - even using --pinned --latest. However, `poetry add @latest --group dev' will update it to the correct version.

I think this is down to versions <1 see this line link to code

@mustafa0x
Copy link

Yes, it doesn't update "0.x.x" deps. I replace "0.x.x" deps with '*' so that the plugin updates those deps.

@georgereynolds-metoffice

I've updated the code to allow for this. I'll try and get a pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants