Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add option to include zero based carets dependencies #64

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

TheSuperiorStanislav
Copy link
Contributor

@TheSuperiorStanislav TheSuperiorStanislav commented Aug 9, 2024

By default, the plugin ignores zero-based carets. But this option to update them too will be useful for many popular packages that are still 0.*.* version. For example fastapi or uvicorn.

Closes #41

@TheSuperiorStanislav
Copy link
Contributor Author

@MousaZeidBaker Could you take a look?

@uuip
Copy link

uuip commented Aug 28, 2024

The plugin's README doesn’t mention this issue at all--"By default, the plugin ignores zero-based carets. ".
I initially thought it was a bug in version parsing, but after reviewing the code, I found some special handling that seems unnecessary.
Since we're using --latest, everything except those locked to specific versions should be upgraded. By default, 0.x versions should be upgraded. On the computer I use, I simply deleted those 4 lines of code. I think this plugin has quite a lot of options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doesn't update dependency
2 participants