-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "wide" option to Datawrapper #12867
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robdivincenzo
changed the title
[WIP] Add "wide" option to Datawrapper
Add "wide" option to Datawrapper
Sep 20, 2024
robdivincenzo
temporarily deployed
to
foundation-s-tp1-143-10-wgcc8s
September 20, 2024 15:33
Inactive
danielfmiranda
approved these changes
Sep 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @robdivincenzo! LGTM 🚀
robdivincenzo
temporarily deployed
to
foundation-s-tp1-143-10-uevyf4
September 24, 2024 16:12
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the
datawrapper
block to aStuctBlock
and adds an additionalWide
option checkbox to make thedatawrapper
expand beyond the regular content width on large screens.Similar to the Add
wide
option to Table PR, except the default here is that it should not be wide because it currently isn't on production.Related PRs/issues: TP1-143 / #10331 / #10163
To Test
Wide
checkbox option on the edit screen.Wide
checkbox for the datawrapper.Wide
checkbox for a datawrapper and save the page┆Issue is synchronized with this Jira Story