Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "wide" option to Datawrapper #12867

Merged
merged 14 commits into from
Sep 24, 2024

Conversation

robdivincenzo
Copy link
Collaborator

@robdivincenzo robdivincenzo commented Sep 12, 2024

Description

This PR updates the datawrapper block to a StuctBlock and adds an additional Wide option checkbox to make the datawrapper expand beyond the regular content width on large screens.

Similar to the Add wide option to Table PR, except the default here is that it should not be wide because it currently isn't on production.

Related PRs/issues: TP1-143 / #10331 / #10163

To Test

  1. View an example page on production with a datawrapper
  2. Note the datawrapper is the same width as the content, and that there is no Wide checkbox option on the edit screen.
  3. Checkout this branch locally
  4. Pull the database from live / stage
  5. View the example page locally
  6. Verify the datawrapper is still there and has the same width as the content.
  7. Verify that on the edit screen that there is now a Wide checkbox for the datawrapper.
  8. Check the Wide checkbox for a datawrapper and save the page
  9. Verify the datawrapper now expands beyond the content width (but remains same width on mobile).

┆Issue is synchronized with this Jira Story

@robdivincenzo robdivincenzo changed the title [WIP] Add "wide" option to Datawrapper Add "wide" option to Datawrapper Sep 20, 2024
@robdivincenzo robdivincenzo marked this pull request as ready for review September 20, 2024 15:27
@robdivincenzo robdivincenzo temporarily deployed to foundation-s-tp1-143-10-wgcc8s September 20, 2024 15:33 Inactive
Copy link
Collaborator

@danielfmiranda danielfmiranda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @robdivincenzo! LGTM 🚀

@robdivincenzo robdivincenzo temporarily deployed to foundation-s-tp1-143-10-uevyf4 September 24, 2024 16:12 Inactive
@mofodevops mofodevops temporarily deployed to foundation-s-tp1-143-10-bwgssi September 24, 2024 16:13 Inactive
@mofodevops mofodevops temporarily deployed to foundation-s-tp1-143-10-fewgjl September 24, 2024 16:59 Inactive
@robdivincenzo robdivincenzo merged commit a284b31 into main Sep 24, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants