Custom emoji mapping #2198
Merged
Custom emoji mapping #2198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pomax
force-pushed
the
custom-emoji-mapping
branch
from
b9e259b
to
a2254c8
Compare
Pomax
commented
Nov 15, 2018
| @@ -21,7 +21,7 @@ | |||
| "optimize:png": "find source/images -type f -name '*.png' -print0 | xargs -0 -n 1 -P 6 optipng", | |||
| "optimize": "run-p optimize:**", | |||
| "server": "pipenv run python network-api/manage.py runserver", | |||
| "start": "npm i && npm run build-uncompressed && run-p server watch:**", | |||
| "start": "npm i && run-p build-uncompressed server watch:**", | |||
There was a problem hiding this comment.
mostly a dev Quality of Life change - this starts the server way earlier, so you can just reload the tab once webpack finishes the build, instead of getting a "server not found" for like... a minute
kristinashu
approved these changes
Nov 15, 2018
mmmavis
reviewed
Nov 15, 2018
| // creepy by default. | ||
| // | ||
| // Note: this is a cosmetic value for scroll only. | ||
| const MAXIMUM_CREEPINESS_RATING = 80; |
There was a problem hiding this comment.
Are MINIMUM_HAPPINESS_RATING and MAXIMUM_CREEPINESS_RATING both fixed values unrelated to EMOJI_FRAME_HEIGHT and SPRITE_FRAME_COUNT? If there's any relationship between them I think it's worth adding some inline comments in case we decide to change the values for frame height and frame count in the future.
There was a problem hiding this comment.
There is zero relation between the two sets of numbers.
mmmavis
approved these changes
Nov 15, 2018
This was referenced Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2196, as long as we can make sure the minimum and maximum values are acceptable =)