Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regrets Reporter Extension landing bottom half #7838

Merged
merged 18 commits into from
Nov 18, 2021

Conversation

danielfmiranda
Copy link
Collaborator

@danielfmiranda danielfmiranda commented Nov 12, 2021

Closes #7794
Related PRs/issues: Depends on #7832

Link to sample test page: https://foundation-s-yt-regrets-hbwxss.herokuapp.com/en/youtube/regretsreporter/

Steps to test:

  1. Please visit the test link above, which should take you to the landing page for the regrets reporter extension
  2. At the moment, the page should just display the 3 column text content, which then turns into 2 columns from large -> small breakpoints, then to 1 column on mobile.
  3. If the text and the formatting looks OK, testing is complete!

Link to figma comp for comparison: https://www.figma.com/file/A0TYlvLzKxnQLZr3unohQy/YouTube-RegretsReporter---product-page-test?node-id=232%3A1216

@mofodevops mofodevops temporarily deployed to foundation-s-yt-regrets-hbwxss November 12, 2021 01:15 Inactive
@github-actions
Copy link

This PR introduces visual differences. Click here to inspect the diffs.

@danielfmiranda danielfmiranda temporarily deployed to foundation-s-yt-regrets-hbwxss November 12, 2021 05:10 Inactive
@danielfmiranda danielfmiranda changed the title [TEST] Yt regrets landing bottom half Regrets Reporter Extension landing bottom half Nov 12, 2021
@github-actions
Copy link

This PR introduces visual differences. Click here to inspect the diffs.

@danielfmiranda danielfmiranda temporarily deployed to foundation-s-yt-regrets-hbwxss November 12, 2021 19:10 Inactive
@danielfmiranda
Copy link
Collaborator Author

Hi @kristinashu! I have a quick question regarding the links for this page.

According to the figma comp, there are two links on the page, and I was not sure where they were supposed to link to so I made my best guess:

The text "Research powered by Mozilla’s RegretsReporter has revealed" links to: https://foundation-s-yt-regrets-hbwxss.herokuapp.com/campaigns/regrets-reporter/findings

and the text "in September 2020" links to: https://foundation-s-yt-regrets-hbwxss.herokuapp.com/campaigns/regrets-reporter

Is this correct? If not, please let me know and I can update them with the correct URLs. Thank you!

@danielfmiranda danielfmiranda linked an issue Nov 12, 2021 that may be closed by this pull request
4 tasks
@github-actions
Copy link

This PR introduces visual differences. Click here to inspect the diffs.

@kristinashu
Copy link

Hi @danielfmiranda, sorry but I'm not sure about those links (I think the urls will be updated). @beccaklam will be back on Monday and can review this then. Will this text be update-able in the CMS?

Copy link

@beccaklam beccaklam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @danielfmiranda! Thanks for flagging about the links and sorry I didn't provide those earlier. The "Research powered by Mozilla’s RegretsReporter has revealed" link is correct but the "in September 2020" link should go to https://foundation.mozilla.org/blog/mozilla-crowdsourcing-research-youtube-recommendations/ I also added a link to the copy doc in the hand off doc (under the figma link) for future reference if it's needed. Otherwise the text formatting looks good to me!

@kristinashu kristinashu removed their request for review November 16, 2021 18:04
@danielfmiranda danielfmiranda temporarily deployed to foundation-s-yt-regrets-hbwxss November 17, 2021 20:33 Inactive
@danielfmiranda danielfmiranda temporarily deployed to foundation-s-yt-regrets-hbwxss November 17, 2021 20:33 Inactive
@danielfmiranda danielfmiranda temporarily deployed to foundation-s-yt-regrets-hbwxss November 17, 2021 20:42 Inactive
@danielfmiranda
Copy link
Collaborator Author

Hi @beccaklam thank you for your feedback!

I have updated the links with the links that you sent me and rerequested review 😄, however, I did want to note that since it is linking to a blog page that was creating on the live foundation site, my review site will return a 404. However, on the foundation site, it will link correctly. Thanks!

@danielfmiranda danielfmiranda changed the title Regrets Reporter Extension landing bottom half [Do not merge] Regrets Reporter Extension landing bottom half Nov 17, 2021
Copy link

@beccaklam beccaklam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link looks good to me! Thanks @danielfmiranda!

@danielfmiranda danielfmiranda temporarily deployed to foundation-s-yt-regrets-hbwxss November 18, 2021 20:32 Inactive
@danielfmiranda danielfmiranda changed the title [Do not merge] Regrets Reporter Extension landing bottom half Regrets Reporter Extension landing bottom half Nov 18, 2021
@danielfmiranda danielfmiranda merged commit b91f7fa into main Nov 18, 2021
@danielfmiranda danielfmiranda deleted the yt-regrets-landing-bottom-half branch November 18, 2021 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create the 3 column "bottom half" of the page
5 participants