-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regrets Reporter Extension landing bottom half #7838
Conversation
…n.mozilla.org into yt-extension-page-base
…n.mozilla.org into yt-extension-page-base
This PR introduces visual differences. Click here to inspect the diffs. |
This PR introduces visual differences. Click here to inspect the diffs. |
Hi @kristinashu! I have a quick question regarding the links for this page. According to the figma comp, there are two links on the page, and I was not sure where they were supposed to link to so I made my best guess: The text "Research powered by Mozilla’s RegretsReporter has revealed" links to: https://foundation-s-yt-regrets-hbwxss.herokuapp.com/campaigns/regrets-reporter/findings and the text "in September 2020" links to: https://foundation-s-yt-regrets-hbwxss.herokuapp.com/campaigns/regrets-reporter Is this correct? If not, please let me know and I can update them with the correct URLs. Thank you! |
This PR introduces visual differences. Click here to inspect the diffs. |
Hi @danielfmiranda, sorry but I'm not sure about those links (I think the urls will be updated). @beccaklam will be back on Monday and can review this then. Will this text be update-able in the CMS? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @danielfmiranda! Thanks for flagging about the links and sorry I didn't provide those earlier. The "Research powered by Mozilla’s RegretsReporter has revealed" link is correct but the "in September 2020" link should go to https://foundation.mozilla.org/blog/mozilla-crowdsourcing-research-youtube-recommendations/ I also added a link to the copy doc in the hand off doc (under the figma link) for future reference if it's needed. Otherwise the text formatting looks good to me!
Hi @beccaklam thank you for your feedback! I have updated the links with the links that you sent me and rerequested review 😄, however, I did want to note that since it is linking to a blog page that was creating on the live foundation site, my review site will return a 404. However, on the foundation site, it will link correctly. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The link looks good to me! Thanks @danielfmiranda!
Closes #7794
Related PRs/issues: Depends on #7832
Link to sample test page: https://foundation-s-yt-regrets-hbwxss.herokuapp.com/en/youtube/regretsreporter/
Steps to test:
Link to figma comp for comparison: https://www.figma.com/file/A0TYlvLzKxnQLZr3unohQy/YouTube-RegretsReporter---product-page-test?node-id=232%3A1216