Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optionally disable drag-gestures in not-zoomed state #8

Merged

Conversation

ajans
Copy link
Contributor

@ajans ajans commented Apr 6, 2022

This improves page-swiping in HorizontalPager from accompanist or standard horizontal lists which use Zoomable (e.g. image-galleries).
For that use-case, set the swipeEnabled-parameter to false to disable swipe-gestures in the unzoomed-state for Zoomable (so dragging-gestures in zoomed-state still work).

This improves page-swiping in HorizontalPager
or horizontal lists.
Copy link
Owner

@Mr-Pine Mr-Pine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you change the target of this PR to the development branch as I'd like master to contain the code that's published to mavenCentral?

@Mr-Pine
Copy link
Owner

Mr-Pine commented Apr 6, 2022

Also, I'll probably rework this a little so that disabling dragging when zoomed in is possible, too.

You can incorporate that into this PR yourself if you want to, of course.

@ajans ajans changed the base branch from master to development April 6, 2022 12:11
@ajans
Copy link
Contributor Author

ajans commented Apr 6, 2022

I changed the PR-target.
Regarding your proposed rework, I am not quite sure how you want it to look like, so I think its better if you do that.

@Mr-Pine Mr-Pine merged commit 9a19757 into Mr-Pine:development Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants