-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Darkmode and gif optimization. #12
Conversation
For the next time. This PR should be actually split into two or three separate ones. One for dark theme, one for tinygif/preview stuff and a third one for other misc changes. That way it would be easier to review. |
Agreed, apologies for all in one, was working on it late last night and got carried away |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is probably close to merging. You can also add ability to select dark theme in storybook for easier testing https://github.com/MrBartusek/gif-picker-react/blob/master/src/stories/GifPicker.stories.tsx#L10-L35
Thank you! |
Sorry missed those last few comments the other day. Thanks for making the changes and merging! |
tnygif
as the query param instead reduces these values by 100-1000x.Bump to minor version 1.1.0 since this includes some non patch related upgrades. None of these changes should be breaking changes.