Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Darkmode and gif optimization. #12

Merged
merged 19 commits into from
Jan 14, 2023
Merged

Conversation

0xM4m4n
Copy link
Contributor

@0xM4m4n 0xM4m4n commented Jan 11, 2023

  • Added the option to pass minimal or basic for media filter. Originally when browsing the picker the gifs were loading at full resolution. My client browser was loading anywhere from 500kb to 40MB per gif. Using tnygif as the query param instead reduces these values by 100-1000x.
  • Added an option to pass light / darkmode theme
  • Bump to minor version 1.1.0 since this includes some non patch related upgrades. None of these changes should be breaking changes.
  • Tested on storybook locally no issues.

README.md Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
src/GifPickerReact.css Outdated Show resolved Hide resolved
@MrBartusek MrBartusek added the enhancement New feature or request label Jan 11, 2023
src/GifPickerReact.css Outdated Show resolved Hide resolved
src/GifPickerReact.css Outdated Show resolved Hide resolved
src/GifPickerReact.tsx Outdated Show resolved Hide resolved
src/components/header/ClearButton.css Show resolved Hide resolved
src/managers/TenorManager.ts Outdated Show resolved Hide resolved
src/managers/TenorManager.ts Outdated Show resolved Hide resolved
@MrBartusek
Copy link
Owner

For the next time. This PR should be actually split into two or three separate ones. One for dark theme, one for tinygif/preview stuff and a third one for other misc changes. That way it would be easier to review.

README.md Show resolved Hide resolved
src/managers/TenorManager.ts Outdated Show resolved Hide resolved
src/GifPickerReact.css Outdated Show resolved Hide resolved
@0xM4m4n
Copy link
Contributor Author

0xM4m4n commented Jan 11, 2023

For the next time. This PR should be actually split into two or three separate ones. One for dark theme, one for tinygif/preview stuff and a third one for other misc changes. That way it would be easier to review.

Agreed, apologies for all in one, was working on it late last night and got carried away

src/managers/TenorManager.ts Outdated Show resolved Hide resolved
src/GifPickerReact.css Outdated Show resolved Hide resolved
src/GifPickerReact.tsx Outdated Show resolved Hide resolved
src/components/PickerMain.tsx Outdated Show resolved Hide resolved
src/managers/TenorManager.ts Outdated Show resolved Hide resolved
src/types/exposedTypes.ts Outdated Show resolved Hide resolved
src/managers/TenorManager.ts Outdated Show resolved Hide resolved
src/hooks/useSettings.ts Outdated Show resolved Hide resolved
@0xM4m4n 0xM4m4n changed the title Darkmode and gif optimization. Bump to 1.1 MINOR Darkmode and gif optimization. Jan 12, 2023
Copy link
Owner

@MrBartusek MrBartusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably close to merging. You can also add ability to select dark theme in storybook for easier testing https://github.com/MrBartusek/gif-picker-react/blob/master/src/stories/GifPicker.stories.tsx#L10-L35

src/GifPickerReact.css Outdated Show resolved Hide resolved
src/GifPickerReact.css Outdated Show resolved Hide resolved
src/managers/TenorManager.ts Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@MrBartusek
Copy link
Owner

image
Close hover is too light

@MrBartusek
Copy link
Owner

image
Loading placeholders are white

README.md Outdated Show resolved Hide resolved
@MrBartusek MrBartusek merged commit 17262e9 into MrBartusek:master Jan 14, 2023
@MrBartusek
Copy link
Owner

Thank you!

@0xM4m4n
Copy link
Contributor Author

0xM4m4n commented Jan 15, 2023

Sorry missed those last few comments the other day. Thanks for making the changes and merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants