Fix mobile viewer toolbars #701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for documentcloud-frontend ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||
Just testing this in Chrome's dev tools, I can get to a state where the dropdown is open but invisible. I put in a search and submitted, and then tried to search again and got stuck here. |
Ah, the search is set to appear above, but it's hidden by the scroll position. I'll switch it to appear below instead. |
eyeseast
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds responsive logic for the viewer's search input, disclosing it inside a dropdown when on mobile. This prevents the viewer's top toolbar from overflowing the viewport at narrow screen widths.
In addition, this adds a preprocessor to modify the behavior of
bind:clientWidth. The default behavior addsstyle="position: relative", which is undesirable for our toolbars, which rely on definite placement within the stacking context for correct menu behavior and sticky positioning. This preprocessor also uses a more performant method of binding to clientWidth by usingResizeObserverinstead ofiframehackery. This might be fixed in Svelte 5.