Merge pull request #2426 from MushroomObserver/translations-term-date

Switch search translation tag keys from `_date` to `_when`

app/classes/pattern_search/observation.rb

@@ -5,7 +5,7 @@ module PatternSearch
   class Observation < Base
     PARAMS = {
       # dates / times
-      date: [:date, :parse_date_range],
+      when: [:date, :parse_date_range],
       created: [:created_at, :parse_date_range],
       modified: [:updated_at, :parse_date_range],
 

config/locales/en.txt

@@ -1142,7 +1142,7 @@
   search_term_comments: comments
   search_term_confidence: confidence
   search_term_created: created
-  search_term_date: date
+  search_term_when: date
   search_term_deprecated: deprecated
   search_term_east: east
   search_term_exclude_consensus: exclude_consensus
@@ -3664,7 +3664,7 @@
   # Search bar help
   pattern_search_terms_help: "Your search string may contain terms of the form \"variable:value\", where value can be quoted, and in some cases can contain more than one value separated by commas.  Recognized variables include:"
 
-  observation_term_date: Date mushroom was observed; YYYY-MM-DD, YYYY or MM; ranges okay.
+  observation_term_when: Date mushroom was observed; YYYY-MM-DD, YYYY or MM; ranges okay.
   observation_term_created: Date observation was first posted.
   observation_term_modified: Date observation was last modified.
   observation_term_name: Consensus name is one of these names.

db/migrate/20240916224214_change_search_term_date_translation_tags.rb

@@ -0,0 +1,14 @@
+class ChangeSearchTermDateTranslationTags < ActiveRecord::Migration[7.1]
+  def up
+    TranslationString.rename_tags(
+      { search_term_date: :search_term_when,
+        observation_term_date: :observation_term_when }
+    )
+  end
+  def down
+    TranslationString.rename_tags(
+      { search_term_when: :search_term_date,
+        observation_term_when: :observation_term_date }
+    )
+  end
+end