Switch .count to .size where appropriate

app/classes/pivotal.rb

@@ -12,7 +12,7 @@ def get_stories(_verbose = false)
       stories = []
 
       request_stories("", stories)
-      request_stories("&offset=501", stories) if stories.count == 500
+      request_stories("&offset=501", stories) if stories.size == 500
 
       stories
     end

app/classes/query/modules/high_level_queries.rb

@@ -33,7 +33,7 @@ module Query::Modules::HighLevelQueries
 
   # Number of results the query returns.
   def num_results(_args = {})
-    @num_results ||= result_ids&.count || 0
+    @num_results ||= result_ids&.size || 0
   end
 
   # Array of all results, just ids.
@@ -67,7 +67,7 @@ def results(args = {})
   # better all be valid instances of +model+ -- no error checking is done!!
   def results=(list)
     @result_ids = list.map(&:id)
-    @num_results = list.count
+    @num_results = list.size
     @results = list.each_with_object({}) do |obj, map|
       map[obj.id] ||= obj
     end
@@ -78,7 +78,7 @@ def results=(list)
   # better all be valid Integer ids -- no error checking is done!!
   def result_ids=(list)
     @result_ids = list
-    @num_results = list.count
+    @num_results = list.size
   end
 
   # Get index of a given record / id in the results.
@@ -112,7 +112,7 @@ def paginate_ids(paginator)
         ids = ids.select { |id| @letters[id] == letter }
       end
     end
-    paginator.num_total = ids.count
+    paginator.num_total = ids.size
     ids[paginator.from..paginator.to] || []
   end
 

app/classes/suggestion.rb

@@ -68,7 +68,7 @@ def name_with_most_observations(names)
     best_name = nil
     best_count = -1
     names.each do |name|
-      count = name.observations.count
+      count = name.observations.size
       next if count <= best_count
 
       best_name = name

app/controllers/account/preferences_controller.rb

@@ -100,7 +100,7 @@ def update_pref(pref, val)
     def update_content_filter(pref, val)
       filter = ContentFilter.find(pref)
       @user.content_filter[pref] =
-        if filter.type == :boolean && filter.prefs_vals.count == 1
+        if filter.type == :boolean && filter.prefs_vals.one?
           val == "1" ? filter.prefs_vals.first : filter.off_val
         else
           val.to_s

app/controllers/collection_numbers_controller.rb

@@ -350,7 +350,7 @@ def figure_out_where_to_go_back_to
       @back_object = Observation.safe_find(@back)
       return if @back_object
 
-      @back_object = if @collection_number.observations.count == 1
+      @back_object = if @collection_number.observations.one?
                        @collection_number.observations.first
                      else
                        @collection_number

app/controllers/herbarium_records_controller.rb

@@ -413,7 +413,7 @@ def figure_out_where_to_go_back_to
       @back_object = Observation.safe_find(@back)
       return if @back_object
 
-      @back_object = if @herbarium_record.observations.count == 1
+      @back_object = if @herbarium_record.observations.one?
                        @herbarium_record.observations.first
                      else
                        @herbarium_record

app/controllers/names/synonyms_controller.rb

@@ -155,7 +155,7 @@ def split_off_desynonymized_names(main_name, checks)
       pick_one = other_group.shift
       pick_one.clear_synonym
       other_group.each { |n| pick_one.transfer_synonym(n) }
-      main_name.clear_synonym if main_name.reload.synonyms.count <= 1
+      main_name.clear_synonym if main_name.reload.synonyms.size <= 1
     end
 
     def dump_sorter(sorter)

app/helpers/locations_helper.rb

@@ -11,7 +11,7 @@ def country_link(country, count = nil)
   # title of a link to Observations at a location, with observation count
   # Observations at this Location(nn)
   def show_obs_link_title_with_count(location)
-    "#{:show_location_observations.t} (#{location.observations.count})"
+    "#{:show_location_observations.t} (#{location.observations.size})"
   end
 
   def calc_counts(locations)

app/helpers/object_link_helper.rb

@@ -133,7 +133,7 @@ def user_link(user, name = nil, args = {})
   def user_list(title, users = [])
     return safe_empty unless users&.any?
 
-    title = users.count > 1 ? title.to_s.pluralize.to_sym.t : title.t
+    title = users.size > 1 ? title.to_s.pluralize.to_sym.t : title.t
     links = users.map { |u| user_link(u, u.legal_name) }
     # interpolating would require inefficient #sanitize
     # or dangerous #html_safe
@@ -163,7 +163,7 @@ def description_link(desc)
   end
 
   def observation_herbarium_record_link(obs)
-    count = obs.herbarium_records.count
+    count = obs.herbarium_records.size
     if count.positive?
 
       link_to((count == 1 ? :herbarium_record.t : :herbarium_records.t),

app/models/observation.rb

@@ -971,6 +971,7 @@ def dump_votes
   end
 
   # Has anyone proposed a given Name yet for this observation?
+  # Count is ok here because we have eager-loaded the namings.
   def name_been_proposed?(name)
     namings.count { |n| n.name == name }.positive?
   end

app/presenters/matrix_box_presenter.rb

@@ -120,7 +120,7 @@ def user_to_presenter(user)
     # user.contribution and observations.count are just numbers.
     self.detail = "#{:list_users_joined.t}: #{user.created_at.web_date}<br/>
                    #{:list_users_contribution.t}: #{user.contribution}<br/>
-                   #{:Observations.t}: #{user.observations.count}".html_safe
+                   #{:Observations.t}: #{user.observations.size}".html_safe
     # rubocop:enable Rails/OutputSafety
     self.name = user.unique_text_name
     self.what = user

app/views/account/preferences/_filters.html.erb

@@ -6,10 +6,10 @@
 
 <% ContentFilter.all.each do |filter| %>
 
-  <% if filter.type == :boolean && filter.prefs_vals.count == 1 %>
+  <% if filter.type == :boolean && filter.prefs_vals.one? %>
     <%= render(partial: "account/preferences/filters/checkbox",
                locals: { filter: filter, f: f }) %>
-  <% elsif filter.type == :boolean && filter.prefs_vals.count > 1 %>
+  <% elsif filter.type == :boolean && filter.prefs_vals.size > 1 %>
     <%= render(partial: "account/preferences/filters/select",
                locals: { filter: filter, f: f }) %>
   <% elsif filter.type == [:string] %>

app/views/collection_numbers/_form.html.erb

@@ -15,7 +15,7 @@ end
 <%= form_with(model: @collection_number, url: url_params,
               local: local, id: "collection_number_form") do |f| %>
 
-  <% if @collection_number.observations.count > 1 %>
+  <% if @collection_number.observations.size > 1 %>
     <%= alert_block(
       :warning, :edit_affects_multiple_observations.t(type: :collection_number)
     ) %>

app/views/herbarium_records/_form.html.erb

@@ -15,7 +15,7 @@ end
 <%= form_with(model: @herbarium_record, url: url_params,
               local: local, id: "herbarium_record_form") do |f| %>
 
-  <% if @herbarium_record.observations.count > 1 %>
+  <% if @herbarium_record.observations.size > 1 %>
     <%= alert_block(
       :warning, :edit_affects_multiple_observations.t(type: :herbarium_record)
     ) %>

app/views/names/synonyms/_fields_existing.html.erb

@@ -1,6 +1,6 @@
 <%# existing synonyms %>
 
-<% if current_synonyms.count > 1 %>
+<% if current_synonyms.size > 1 %>
   <%= fields_for(:existing_synonyms) do |fes| %>
     <div class="form-group">
       <%= content_tag(:div, "#{:form_synonyms_current_synonyms.t}:",

app/views/observations/show/_collection_numbers.html.erb

@@ -51,7 +51,7 @@ cn_query = Query.lookup(:CollectionNumber, :all, observations: obs.id)
     </ul>
 
   <% elsif numbers.any? && !can_edit %>
-    <%= numbers.count > 1 ? :Collection_numbers.t : :Collection_number.t %>:
+    <%= numbers.size > 1 ? :Collection_numbers.t : :Collection_number.t %>:
     <%= numbers.map do |number|
           link_to("<i>#{number.format_name.t}</i>".html_safe,
                   collection_number_path(id: number.id, q: cn_query),

app/views/observations/show/_herbarium_records.html.erb

@@ -53,7 +53,7 @@ query = Query.lookup(:HerbariumRecord, :all, observations: obs.id)
 
   <% elsif records.any? && !can_add %>
     <div>
-      <%= records.count > 1 ? :Herbarium_records.t : :Herbarium_record.t %>:
+      <%= records.size > 1 ? :Herbarium_records.t : :Herbarium_record.t %>:
     </div>
     <ul class="tight-list">
       <% records.each do |record| %>

app/views/pivotal/index.html.erb

@@ -48,8 +48,8 @@
 %>
 
 <div class="container-text">
-  <% if @stories.count > 900 %>
-    <b>Displaying <%= @stories.count %> of 1,000 available Feature Requests. Please <%= link_to 'let the admins know', '/emails/ask_webmaster_question', title: "Contact Us" %> that we're close to the limit.</b>
+  <% if @stories.size > 900 %>
+    <b>Displaying <%= @stories.size %> of 1,000 available Feature Requests. Please <%= link_to 'let the admins know', '/emails/ask_webmaster_question', title: "Contact Us" %> that we're close to the limit.</b>
   <% end %>
   <%= :pivotal_index_header.tp %>
 </div><!--.container-text-->