Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to dartsass-sprockets for SCSS compilation #2050

Merged
merged 1 commit into from
Mar 21, 2024
Merged

Conversation

nimmolo
Copy link
Contributor

@nimmolo nimmolo commented Mar 21, 2024

This is a drop-in replacement for the unmaintained sassc-rails and (unlike the official dartsass-rails) doesn't mean changing the way we run our local servers, rails s.

This unblocks compilation of Bootstrap 4/5 which use current SCSS syntax.

Switching to dartsass-rails and dropping sprockets in favor of propshaft may be desirable in the future. dartsass-rails uses foreman and you'd run bin/dev to start your local server.

This is a drop-in replacement for `sassc-rails` and doesn't mean dropping `sprockets` yet, or changing the way you run the local server `rails s`.

Switching to `dartsass-rails` and dropping `sprockets` may be desirable in the future.
@coveralls
Copy link
Collaborator

Coverage Status

coverage: 94.418%. remained the same
when pulling a913194 on dartsass-sprockets
into c6c3908 on main.

@nimmolo nimmolo marked this pull request as ready for review March 21, 2024 18:22
@nimmolo nimmolo requested a review from JoeCohen March 21, 2024 18:26
@nimmolo nimmolo merged commit 7ce286d into main Mar 21, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants