Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the not_in_box scope #2461

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from
Draft

Fix the not_in_box scope #2461

wants to merge 13 commits into from

Conversation

nimmolo
Copy link
Contributor

@nimmolo nimmolo commented Oct 6, 2024 •
edited
Loading

  • Corrects not_in_box to return the set of observations not within the given box as per the in_box definition, but leave out observations with no geolocation or location.
  • Maintains the definition of Project constraint violations, which remains "if the observation is not in the box, or observation location not entirely contained in box".

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 93.467% (-0.003%) from 93.47%
when pulling 7132304 on try-new-not_in_box
into 42dd7eb on main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nimmolo @coveralls