Increase wasm memory limit to 3mb #1035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we go much bigger? |
probably, not sure how'd that effect things though |
|
tried 3gb and things stopped working so there is an upper limit |
|
More research should be made into this parameter change, and commented in the file. |
|
Tried 30mb and things worked fine, imo it'd make sense to increase to 3mb and see how it behaves. 2mb increase is basically nothing on modern devices and we can see if the out of bounds issues go away. If not we can look into large increases to the limit |
benthecarman
force-pushed
the
increase-wasm-memory
branch
from
2eea591
to
6aca3a0
Compare
|
That sounds good but I want to know more before we change anything. Surely you found out about this somewhere. |
|
sorry thought i linked it |
TonyGiorgio
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While debugging #1032 found how to increase our memory for wasm. This will 3x from the default stack size to 3mb.