Android Forms activity needs to forward events to ActivityLifetimeListener #1762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martijn00
approved these changes
May 3, 2017
| using Xamarin.Forms; | ||
| using Xamarin.Forms.Internals; | ||
| using Xamarin.Forms.Platform.iOS; | ||
| using IosMvxImageView = MvvmCross.Binding.iOS.Views.MvxImageView; |
There was a problem hiding this comment.
Always start naming conventions with Mvx. So MvxIosImageView
| { | ||
| class MvxImageViewRenderer : ImageRenderer | ||
| { | ||
| private IosMvxImageView _NativeControl { get; set; } |
There was a problem hiding this comment.
Private accessors should not start with capital letter. _nativeControl
| @@ -89,18 +90,18 @@ protected IMvxImageHelper<Bitmap> ImageHelper | |||
| } | |||
| } | |||
|
|
|||
| public MvxImageView(Context context, IAttributeSet attrs, int defStyleAttr) | |||
| public MvxImageView(Context context, IAttributeSet attrs, int defStyleAttr, Action afterImageChangeAction = null) | |||
There was a problem hiding this comment.
Can we rename this to imageChanged or something?
There was a problem hiding this comment.
Of course, I used the variable name from the iOS version so I'll change both
| @@ -13,8 +13,8 @@ using Xamarin.Forms.Platform.Android; | |||
| namespace Namespace | |||
| { | |||
| [Activity(Label = "View for anyViewModel", ScreenOrientation=ScreenOrientation.Portrait)] | |||
| public class MvxFormsApplicationActivity | |||
| : FormsApplicationActivity | |||
| public class MyApplicationActivity | |||
There was a problem hiding this comment.
Do we still need to keep this file?
|
Done |
martijn00
reviewed
May 3, 2017
| @@ -138,7 +149,7 @@ | |||
| </ProjectReference> | |||
| </ItemGroup> | |||
| <ItemGroup> | |||
| <None Include="MvxFormsApplicationActivity.cs.txt" /> | |||
| <None Include="MyApplicationActivity.cs.txt" /> | |||
There was a problem hiding this comment.
Also remove it from the csproj
|
Hay forgot to save! |
|
Don't worry, i fixed it. Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.