Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete plugins readme files (#1886) #1890

Merged
merged 2 commits into from
Jun 4, 2017
Merged

Delete plugins readme files (#1886) #1890

merged 2 commits into from
Jun 4, 2017

Conversation

jz5
Copy link
Contributor

@jz5 jz5 commented May 31, 2017

✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)

Update docs (READMEs). Fix #1886

@Cheesebaron
Copy link
Member

Excellent, have you made sure that details from the readme's are not missing from the docs?

@jz5
Copy link
Contributor Author

jz5 commented May 31, 2017

Yes. All links are correct.

@Cheesebaron
Copy link
Member

I am not talking about the links. But the contents of the pages the links point to.

@martijn00
Copy link
Contributor

Why don't we remove all the readme files, because it should all be on the website anyways.

@jz5
Copy link
Contributor Author

jz5 commented Jun 1, 2017

The plugins docs on mvvmcross.com are newer than readmes. And the docs contain the contents of readmes.
But except location.md. I noticed the content of location.md is old. I copied the content from readme to location.md.

@jz5
Copy link
Contributor Author

jz5 commented Jun 1, 2017

Delete readmes?

@MarcBruins MarcBruins added the t/docs Documentation type label Jun 1, 2017
@martijn00
Copy link
Contributor

Yes, i was thinking if we just delete all the Readme.mdfiles in the plugin folders we don't need to link anymore. We already have a link to the website and documentation on the readme.md in the root folder.

@jz5
Copy link
Contributor Author

jz5 commented Jun 3, 2017

I changed the commits to delete.

@martijn00
Copy link
Contributor

Please rebase so we can merge your pr.

@jz5
Copy link
Contributor Author

jz5 commented Jun 4, 2017

OK.
Plugins readmes had typos (#1911). But plugins documents on mvvmcross.com have no typos. (already have fixed).

@jz5 jz5 changed the title 📝 Link to the document on mvvmcross.com (#1886) Delete plugins readme files (#1886) Jun 4, 2017
@martijn00 martijn00 merged commit 799be50 into MvvmCross:develop Jun 4, 2017
@martijn00 martijn00 added this to the 5.0.2 milestone Jun 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t/docs Documentation type
Development

Successfully merging this pull request may close these issues.

Documents: Plugins README are old
4 participants