fix health check ping

Mwindo · Apr 16, 2024 · 59c2b77 · 59c2b77
1 parent 4779e96
commit 59c2b77
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 8 deletions.
diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
@@ -19,12 +19,6 @@ jobs:
         sudo curl -L "https://github.com/docker/compose/releases/download/1.29.2/docker-compose-$(uname -s)-$(uname -m)" -o /usr/local/bin/docker-compose
         sudo chmod +x /usr/local/bin/docker-compose
 
-    - name: Check secret is set
-      env:
-        SECRET: ${{ secrets.DATABASE_DB }}
-      run: |
-        echo "Length of secret: ${#DATABASE_DB}"
-
     - name: Build
       run: |
         docker image prune -a -f

diff --git a/docker-compose-dev-ga.yaml b/docker-compose-dev-ga.yaml
@@ -35,6 +35,6 @@ services:
     ports:
       - "3306:3306"
     healthcheck:
-      test: [ "CMD", "mysqladmin", "ping", "-h", "localhost" ] # We'll wait until the DB is ready to accept connections to start up dependent services
+      test: [ "CMD", "mysqladmin", "ping", "-h", "db" ] # We'll wait until the DB is ready to accept connections to start up dependent services
       timeout: 20s
       retries: 10
diff --git a/docker-compose-dev.yaml b/docker-compose-dev.yaml
@@ -50,6 +50,6 @@ services:
     ports:
       - "3306:3306"
     healthcheck:
-      test: [ "CMD", "mysqladmin", "ping", "-h", "localhost" ] # We'll wait until the DB is ready to accept connections to start up dependent services
+      test: [ "CMD", "mysqladmin", "ping", "-h", "db" ] # We'll wait until the DB is ready to accept connections to start up dependent services
       timeout: 20s
       retries: 10