support 32bits chainid with the latest Ledger app #2094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please see LedgerHQ/app-ethereum@8260268 for some larger chainId cases, returned signature v should be recomputed at the client side.
hackmod
force-pushed
the
ledger-32bits-chainid
branch
from
8185b2e
to
7030990
Compare
This was referenced Jul 30, 2018
ConnorBryan
reviewed
Aug 15, 2018
hackmod
commented
Aug 16, 2018
mkrufky
reviewed
Aug 16, 2018
hackmod
force-pushed
the
ledger-32bits-chainid
branch
from
3636601
to
059404f
Compare
ConnorBryan
approved these changes
Sep 4, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see LedgerHQ/app-ethereum@8260268
for some larger chainId cases, returned signature v should be recomputed at the client side.
Screenshots
for example (ESN - chainId
31102case + Ledger Nano S + the Ethereum app 1.1.2 ),in this case, returned
result.vis0x20or0x1f(1-byte truncated).https://ethersocial.net/tx/0x9e4b5ae1b58720e1ee0e34d2cc0e234162c824aeadfeda51d9edfbf97dfe6299